Skip to content

Fixes 173: import of illegal python identifiers from filenames #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeff-dh wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Fixes 173: import of illegal python identifiers from filenames #174

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cc28da6
added py_scadparser
jeff-dh May 16, 2021
e64dff0
removed unused function extract_callable_signatures
jeff-dh May 16, 2021
49988f2
use py_scadparser
jeff-dh May 16, 2021
243bfd7
fixed wrong openscad function syntax in examples/scad_to_include.scad
jeff-dh May 16, 2021
c749460
added another test module to examples/scad_to_include.scad
jeff-dh May 16, 2021
fe6b85d
fix OpenSCAD identifiers starting with a digit
jeff-dh May 16, 2021
b883cfa
added support for (non)optional arguments
jeff-dh May 16, 2021
9860be4
fixed test_parse_scad_callables
jeff-dh May 19, 2021
1ece137
(hopefully) made run_all_tests.sh more portable
jeff-dh May 19, 2021
010c815
fixed unclosed file handle in py_scadparser
jeff-dh May 19, 2021
9a68259
Merge branch 'openscad_identifiers_starting_with_digits' into fix_173
jeff-dh May 22, 2021
b1ac306
moved [un]subbed_keyword into helpers.py
jeff-dh May 22, 2021
c30cef4
fixed import of illegal python identifiers (#173)
jeff-dh May 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed unused function extract_callable_signatures
  • Loading branch information
@jeff-dh
jeff-dh committed May 16, 2021
commit e64dff08b726ce7cab7c1c5414d66a5f1888321b
3 changes: 0 additions & 3 deletions solid/solidpython.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,9 +611,6 @@ def sp_code_in_scad_comment(calling_file: PathStr) -> str:
# ===========
# = Parsing =
# ===========
def extract_callable_signatures(scad_file_path: PathStr) -> List[dict]:
scad_code_str = Path(scad_file_path).read_text()
return parse_scad_callables(scad_code_str)

def parse_scad_callables(scad_code_str: str) -> List[dict]:
callables = []
Expand Down