test(hosted): temporarily skip the ruby-gem e2e legs (pin unpublished) - #197
Open
Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
Open
test(hosted): temporarily skip the ruby-gem e2e legs (pin unpublished)#197Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
Conversation
The pinned gem patch activestorage@7.0.2.2 (2535d43d) was intentionally unpublished 2026-08-14 pending a corrected republish. Its record still resolves via /patch/view/<uuid>, but the discovery endpoints (/patch/batch, /patch/by-package) now return zero patches for it, so preflight_required_patches_are_published, the advisory canary, and the gem redirect leg fail for reasons unrelated to the CLI — red-lighting the required hosted-e2e check on every PR and on main. Add a single GEM_E2E_DISABLED switch (defaulting true) that skips those three gem legs while keeping npm/PyPI/cargo enforced. The gem redirect leg returns unconditionally (NOT soft_skip!, which panics under STRICT), so it skips cleanly in CI too. Flip the const back to false (and re-point GEM_UUID if the replacement differs) once the corrected patch is live. Verified under SOCKET_PATCH_HOSTED_E2E_STRICT=1 against real production: preflight + canary pass on the three remaining ecosystems, the gem leg prints SKIP and returns; 3 passed, 0 failed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The pinned gem patch
activestorage@7.0.2.2(2535d43d) was intentionally unpublished on 2026-08-14 pending a corrected republish. Its record still resolves via/patch/view/<uuid>, but the discovery endpoints (/patch/batch,/patch/by-package) now return zero patches for it. That failspreflight_required_patches_are_published,canary_patches_name_advisories_so_merge_state_is_inferable, andgem_bundler_hosted_redirect_and_known_install_defect— red-lighting the requiredhosted-e2echeck on every PR and onmain, for reasons unrelated to the CLI. (npm/PyPI/cargo pins are all still healthy.)Fix
One clearly-labeled, easily-reversible switch:
const GEM_E2E_DISABLED: bool = true. While on, the three gem legs skip; npm/PyPI/cargo stay fully enforced. The gem redirect leg returns unconditionally (deliberately NOTsoft_skip!, which panics underSOCKET_PATCH_HOSTED_E2E_STRICT— the disable is intentional in CI, not a missing toolchain). The module-doc table flags the gem row as temporarily disabled.Re-enable
Flip
GEM_E2E_DISABLEDtofalse(and updateGEM_UUIDif the corrected patch has a new uuid) once it is republished onpatches-api.socket.dev.Test
Ran the three affected legs against real production under
SOCKET_PATCH_HOSTED_E2E_STRICT=1:preflight_required_patches_are_published... ok (npm/PyPI/cargo)canary_patches_name_advisories_so_merge_state_is_inferable... okgem_bundler_hosted_redirect_and_known_install_defect... SKIP + oktest result: ok. 3 passed; 0 failedScoped to
e2e_hosted_production.rs(the suite the requiredhosted-e2ejob runs). The synthetice2e_vendor_gem_buildcapstone is offline and unaffected;e2e_vendored_productionis not in the required matrix.🤖 Generated with Claude Code
Note
Low Risk
Test-only change with a documented revert path; no production CLI or runtime behavior is modified.
Overview
Adds
GEM_E2E_DISABLED(true) so hosted production e2e no longer treats the unpublishedactivestorage@7.0.2.2gem pin as required while it is off discovery endpoints.preflight_required_patches_are_publishedandcanary_patches_name_advisories_so_merge_state_is_inferableomit the gem PURL when the flag is on; npm/PyPI/Cargo checks stay enforced.gem_bundler_hosted_redirect_and_known_install_defectreturns early with an explicit SKIP (notsoft_skip!, soSOCKET_PATCH_HOSTED_E2E_STRICTstill passes in CI). Module docs note the gem row is temporarily disabled and how to re-enable.Reviewed by Cursor Bugbot for commit 6962bb9. Configure here.