ci: stop counting docker-e2e/setup-e2e soft-skips as passing tests - #151
Closed
Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
Closed
ci: stop counting docker-e2e/setup-e2e soft-skips as passing tests#151Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
Conversation
The test and test-release jobs ran `cargo test --workspace --all-features`, which also RUNS the feature-gated docker-e2e and setup-e2e suites. Those tests soft-skip as "ok" when no socket-patch-test images exist — which is always true in these jobs (no images are built there; macOS/Windows have no Docker at all). Every OS leg therefore reported dozens of fake green tests, and a broken skip-guard would disable a whole suite while CI stayed green. Split build from run: --all-features --no-run keeps the compile-rot coverage for the gated suites, the run step uses default features only. The dedicated e2e-docker and setup-matrix jobs remain the places where the gated suites actually execute. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
Folded into #150 — the stack was consolidated into a single PR at the author's request; this PR's commit is included there verbatim (cherry-picked, all tests green on the consolidated head). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #150 (base =
fix/sweep-bugfixes-and-test-harness; retarget to main once that lands).The
test(3-OS matrix) andtest-releasejobs runcargo test --workspace --all-features, which also executes the feature-gateddocker_e2e_*/setup_matrix_*suites. In these jobs they always soft-skip — no test images are built there, and macOS/Windows have no Docker — but each skip reports as a passing test. That inflates the green count by dozens per OS leg, and a regressed skip-guard could silently disable a real suite while CI stayed green.Fix: build with
--all-features --no-run(keeps compile-rot coverage for the gated suites), run with default features only. The gated suites keep executing for real in the dedicatede2e-dockerandsetup-matrixjobs.Verification
🤖 Generated with Claude Code
Note
Low Risk
Workflow-only test invocation change; default-feature test coverage is unchanged and gated suites still run in dedicated jobs.
Overview
The
test(3-OS) andtest-releasejobs no longer runcargo testwith--all-features. They now compile the full workspace with--all-features --no-run(still catching compile rot in feature-gated suites), then execute tests with default features only.That stops
docker_e2e_*/setup_matrix_*from running in those jobs and reporting dozens of soft-skip “ok” results where Docker/images are absent—so a broken skip guard can’t keep CI green. Real execution of those suites stays ine2e-dockerandsetup-matrix.Both steps use
bashwithset -euo pipefailon the matrixtestjob.Reviewed by Cursor Bugbot for commit b5513b4. Configure here.