feat(manifest): add socket manifest maven (1.1.124, Coana 15.5.5)#1373
Open
Jeppe Fredsgaard Blaabjerg (jfblaa) wants to merge 2 commits into
Open
feat(manifest): add socket manifest maven (1.1.124, Coana 15.5.5)#1373Jeppe Fredsgaard Blaabjerg (jfblaa) wants to merge 2 commits into
socket manifest maven (1.1.124, Coana 15.5.5)#1373Jeppe Fredsgaard Blaabjerg (jfblaa) wants to merge 2 commits into
Conversation
Add a `socket manifest maven` command that generates a Socket facts file (`.socket.facts.json`) from a Maven `pom.xml` project by delegating to the Coana CLI's `manifest maven` command, mirroring the existing gradle/sbt facts flows. Includes pom.xml auto-detection, `socket manifest auto` wiring, the `socket manifest setup` configurator, socket.json defaults, and `--maven-opts` / `--bin` pass-through. Bump Coana CLI to 15.5.5, which adds the `manifest maven` command this delegates to.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
socket manifest mavencommand that generates a Socket facts file (.socket.facts.json) from a Mavenpom.xmlproject, mirroring the existinggradle/scala (sbt)facts flows. socket-cli delegates to the Coana CLI'smanifest mavencommand (which owns the Maven extension that resolves the dependency graph); socket-cli only constructs the args and verifies the emitted facts file.This is the 1.1.124 release: the feature plus the Coana bump it depends on.
What's included
cmd-manifest-maven.mts— facts-only (Maven is already pom-native, so there is no--pompath). Flags:--bin(defaults tomvnon PATH; point at./mvnwto use a wrapper),--maven-opts(e.g.-P <profile> -s <settings.xml>),--include-configs/--exclude-configs(Maven scopes),--ignore-unresolved,--verbose. Reads defaults fromsocket.jsonlike the other JVM tools.convert-maven-to-facts.mts— thin delegate to the sharedrunCoanaManifestFacts(widened to acceptecosystem: 'maven'/--maven-opts).pom.xml→ maven indetect-manifest-actions.mts, wired intosocket manifest auto(generate_auto_manifest.mts).setupMavenin thesocket manifest setupconfigurator.mavenentry insocket.jsonmanifest defaults.@coana-tech/cli15.5.0 → 15.5.5, which adds themanifest mavencommand this delegates to.Verification
pnpm build:dist:src,pnpm check:tsc,pnpm check:lint,biome formatall clean.cmd-manifest-maven.test.mts(help + dry-run); updatedcmd-manifest.test.mtssnapshot; setup/auto/detect/generate-auto suites pass.tool: "maven"metadata).Note
Low Risk
Additive beta manifest feature following existing Coana delegation; main dependency is the Coana 15.5.5 bump for Maven support.
Overview
Release 1.1.124 adds Maven to the manifest toolchain and bumps @coana-tech/cli to 15.5.5 so Coana can run
manifest maven.socket manifest maven[beta] writes.socket.facts.jsonfrom apom.xmlproject by delegating to Coana (same pattern as Gradle/sbt facts). Flags cover--bin(defaultmvn, or./mvnw),--maven-opts, scope filters via--include-configs/--exclude-configs, and--ignore-unresolved; defaults can live insocket.json.Wiring:
pom.xmlis auto-detected forsocket manifest auto, the setup wizard gets a Maven path (setupMaven), andrunCoanaManifestFactsnow acceptsecosystem: 'maven'with--maven-opts. Docs, changelog, help snapshots, and CLI tests were updated accordingly.Reviewed by Cursor Bugbot for commit dec47bf. Configure here.