Skip to content

feat(ci): add sfw-enterprise support and publish-without-sfw escape hatch #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
John-David Dalton (jdalton) merged 5 commits into from
Apr 9, 2026
Merged

feat(ci): add sfw-enterprise support and publish-without-sfw escape hatch #1181

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
976cb5d
feat(ci): add sfw-enterprise support and publish-without-sfw escape h…
jdalton Apr 9, 2026
d99f936
fix(ci): suppress pre-existing zizmor secrets-outside-env warnings
jdalton Apr 9, 2026
408e3aa
fix(ci): add job names, restrict workflow permissions, document id-token
jdalton Apr 9, 2026
8787282
fix(ci): use file rename instead of PATH override to strip sfw shims
jdalton Apr 9, 2026
6b68dbe
fix(ci): match e2e job name to branch protection requirement
jdalton Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(ci): suppress pre-existing zizmor secrets-outside-env warnings
  • Loading branch information
@jdalton
jdalton committed Apr 9, 2026
commit d99f9363ca4dd1dcf516aadc9ade68ca3fdff8bd
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,5 +145,5 @@ jobs:

- name: Run e2e tests
env:
SOCKET_CLI_API_TOKEN: ${{ secrets.SOCKET_CLI_API_TOKEN }}
SOCKET_CLI_API_TOKEN: ${{ secrets.SOCKET_CLI_API_TOKEN }} # zizmor: ignore[secrets-outside-env]
run: pnpm run e2e-tests
6 changes: 3 additions & 3 deletions .github/workflows/provenance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ jobs:
continue-on-error: true
env:
NPM_DIST_TAG: ${{ inputs.dist-tag }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} # zizmor: ignore[secrets-outside-env]
SOCKET_CLI_DEBUG: ${{ inputs.debug }}
- run: INLINED_SOCKET_CLI_PUBLISHED_BUILD=1 INLINED_SOCKET_CLI_LEGACY_BUILD=1 pnpm run build:dist
env:
Expand All @@ -212,7 +212,7 @@ jobs:
continue-on-error: true
env:
NPM_DIST_TAG: ${{ inputs.dist-tag }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} # zizmor: ignore[secrets-outside-env]
SOCKET_CLI_DEBUG: ${{ inputs.debug }}
- run: INLINED_SOCKET_CLI_PUBLISHED_BUILD=1 INLINED_SOCKET_CLI_SENTRY_BUILD=1 pnpm run build:dist
env:
Expand All @@ -221,7 +221,7 @@ jobs:
continue-on-error: true
env:
NPM_DIST_TAG: ${{ inputs.dist-tag }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} # zizmor: ignore[secrets-outside-env]
SOCKET_CLI_DEBUG: ${{ inputs.debug }}
- name: Restore sfw shims after publishing
if: inputs.publish-without-sfw == true && always()
Expand Down
Loading