Skip to content

fix: respect projectIgnorePaths from socket.yml in scan create #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
John-David Dalton (jdalton) merged 6 commits into from
Apr 2, 2026
Merged

fix: respect projectIgnorePaths from socket.yml in scan create #1137

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7fa104f
fix: respect projectIgnorePaths from socket.yml in scan create
mtorp Mar 31, 2026
5f08205
fix: respect projectIgnorePaths from socket.yml in scan reach
mtorp Mar 31, 2026
7e80f50
Merge branch 'v1.x' of github.com:SocketDev/socket-cli into fix/scan-…
mtorp Apr 1, 2026
55e3874
v1.1.78
mtorp Apr 1, 2026
f9b7f59
fix: respect projectIgnorePaths from socket.yml in socket fix
mtorp Apr 1, 2026
8c453bb
docs: update changelog to include socket fix
mtorp Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: respect projectIgnorePaths from socket.yml in scan create 
The scan create command had all the downstream infrastructure to honor
projectIgnorePaths from socket.yml but never actually loaded the config.
Read socket.yml via findSocketYmlSync and pass the parsed config to
getPackageFilesForScan so globWithGitIgnore applies the ignore patterns.
  • Loading branch information
@mtorp
mtorp committed Mar 31, 2026
commit 7fa104fcd167e53bb72f5c24f311fe813f4b5bc5
1 change: 0 additions & 1 deletion src/commands/scan/cmd-scan-create.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,6 @@ async function run(
...generalFlags,
...reachabilityFlags,
},
// TODO: Your project's "socket.yml" file's "projectIgnorePaths".
help: command => `
Usage
$ ${command} [options] [TARGET...]
Expand Down
9 changes: 9 additions & 0 deletions src/commands/scan/handle-create-new-scan.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { outputCreateNewScan } from './output-create-new-scan.mts'
import { performReachabilityAnalysis } from './perform-reachability-analysis.mts'
import constants from '../../constants.mts'
import { checkCommandInput } from '../../utils/check-input.mts'
import { findSocketYmlSync } from '../../utils/config.mts'
import { getPackageFilesForScan } from '../../utils/path-resolve.mts'
import { readOrDefaultSocketJson } from '../../utils/socket-json.mts'
import { socketDocsLink } from '../../utils/terminal-link.mts'
Expand Down Expand Up @@ -164,7 +165,15 @@ export async function handleCreateNewScan({
spinner.start('Searching for local files to include in scan...')

const supportedFiles = supportedFilesCResult.data

// Load socket.yml to respect projectIgnorePaths when collecting files.
const socketYmlResult = findSocketYmlSync(cwd)
const socketConfig = socketYmlResult.ok
? socketYmlResult.data?.parsed
: undefined

const packagePaths = await getPackageFilesForScan(targets, supportedFiles, {
config: socketConfig,
cwd,
})

Expand Down