Repository navigation
Fix ExprWithFireResistance Mutating Original Item - #8943
Open
erenkarakal wants to merge 1 commit into
Open
erenkarakal wants to merge 1 commit into
erenkarakal wants to merge 1 commit into
Conversation
erenkarakal
requested review from
APickledWalrus and
TheMug06
and removed request for
a team
November 10, 2026 03:52
This comment has been minimized.
This comment has been minimized.
sovdeeth
approved these changes
Nov 10, 2026
APickledWalrus
approved these changes
Nov 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ExprWithFireResistance clones the array instead of the item, causing the original item to be mutated
Solution
Clone the item instead of the array
Testing Completed
Manual in-game test before & after
Supporting Information
Completes: none
Related: none
AI assistance: none