Skip to content

Fix ExprWithFireResistance Mutating Original Item - #8943

Open
erenkarakal wants to merge 1 commit into
SkriptLang:dev/patchfrom
erenkarakal:patch/fix-expr-with-fire-res
Open

erenkarakal wants to merge 1 commit into
SkriptLang:dev/patchfrom
erenkarakal:patch/fix-expr-with-fire-res

Conversation

@erenkarakal

Copy link
Copy Markdown
Member

Problem

ExprWithFireResistance clones the array instead of the item, causing the original item to be mutated

set {_sword} to 1 of diamond sword
set {_copy} to {_sword} with fire resistance
if {_sword} is fire resistant:
    broadcast "resistant"

Solution

Clone the item instead of the array

Testing Completed

Manual in-game test before & after

Supporting Information


Completes: none
Related: none
AI assistance: none

@erenkarakal
erenkarakal requested a review from a team as a code owner November 10, 2026 03:52
@erenkarakal
erenkarakal requested review from APickledWalrus and TheMug06 and removed request for a team November 10, 2026 03:52
@skriptlang-automation skriptlang-automation Bot added needs reviews A PR that needs additional reviews needs triage An issue that hasn't been classified or verified yet labels Nov 10, 2026
@skriptlang-automation

This comment has been minimized.

@skriptlang-automation skriptlang-automation Bot added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Nov 10, 2026
@skriptlang-automation skriptlang-automation Bot removed the needs triage An issue that hasn't been classified or verified yet label Nov 10, 2026
@skriptlang-automation skriptlang-automation Bot moved this to In Review in 2.17 Releases Nov 10, 2026
@skriptlang-automation skriptlang-automation Bot added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Nov 10, 2026
@github-project-automation github-project-automation Bot moved this from In Review to Awaiting Merge in 2.17 Releases Nov 10, 2026
@skriptlang-automation skriptlang-automation Bot removed the needs reviews A PR that needs additional reviews label Nov 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.

Projects

Status: Awaiting Merge

Development

Successfully merging this pull request may close these issues.

3 participants