Fix DecoderOptions handler.#323
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #323 +/- ##
===================================
Coverage 85% 85%
===================================
Files 83 83
Lines 2371 2371
Branches 346 347 +1
===================================
+ Hits 2024 2026 +2
+ Misses 244 242 -2
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The current
OnBeforeLoadAsyncdelegate is useless asDecoderOptionsproperties are init-only. This PR includes an emergency breaking change which updates the method to return options themselves.