Updated the KeyExists from aws to keep the response metadata in the image resolver#317
Conversation
Codecov Report
@@ Coverage Diff @@
## main #317 +/- ##
===================================
- Coverage 85% 85% -1%
===================================
Files 77 77
Lines 2195 2195
Branches 308 309 +1
===================================
- Hits 1876 1873 -3
- Misses 231 233 +2
- Partials 88 89 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
HI @mdupras thanks for this. Would it be possible to revert the nullability changes since they overlap with the other PR which will actually increase the probability of conflicts since there have been changes requested there? |
0eb19fc to
2acb001
Compare
Yea no problem! Just did it! |
JimBobSquarePants
left a comment
There was a problem hiding this comment.
Lovely stuff. Thanks!
Prerequisites
Description
When the image is resolved we validate if it exists with the method
KeyExists. To validate this the methods fetch all the object metadata, if it fails it's considered not existent, but the result of that query isn't used.This PR keeps the result and pass it to the AWS S3 image resolver.
I added an optional parameter for that metadata, in case the resolver needs to be build it elsewhere. If the metadata is not provided, it will fetch it like it used to.
Since I had overlapped change with #312, I included the change of those files in my PR to limit the conflicts and use the nullable options ;)