Skip to content

Remove nullable disable from azure#309

Merged
JimBobSquarePants merged 3 commits into
SixLabors:mainfrom
stefannikolei:stefannikolei/nullable/azure
Mar 6, 2023
Merged

Remove nullable disable from azure#309
JimBobSquarePants merged 3 commits into
SixLabors:mainfrom
stefannikolei:stefannikolei/nullable/azure

Conversation

@stefannikolei

Copy link
Copy Markdown
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

  • Removed all Nullable disable from the azure providers
  • Removed IAzureBlobContainerClientOptions because it wasn't used just for declaration
  • Added convenience DI methods for Adding the cache or image provider. Leaving out the initialization was on purpose to not run that code on startup because it could throw an exception so the app won't start..

* Removed all Nullable disable from the azure providers
* Removed IAzureBlobContainerClientOptions because it wasn't used just for declaration
* Added convenience DI methods for Adding the cache or image provider. Leaving out the initialization was on purpose to not run that code on startup because it could throw an exception so the app won't start..
@stefannikolei stefannikolei force-pushed the stefannikolei/nullable/azure branch from 28be64d to 11cc34c Compare March 5, 2023 15:59
@codecov

codecov Bot commented Mar 5, 2023

Copy link
Copy Markdown

Codecov Report

Merging #309 (11cc34c) into main (e852621) will decrease coverage by 1%.
The diff coverage is 42%.

❗ Current head 11cc34c differs from pull request most recent head bae419e. Consider uploading reports for the commit bae419e to get more accurate results

@@         Coverage Diff         @@
##           main   #309   +/-   ##
===================================
- Coverage    85%    85%   -1%     
===================================
  Files        77     78    +1     
  Lines      2192   2199    +7     
  Branches    304    308    +4     
===================================
- Hits       1879   1877    -2     
- Misses      229    235    +6     
- Partials     84     87    +3     
Flag Coverage Δ
unittests 85% <42%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...b.Providers.Azure/Caching/AzureBlobStorageCache.cs 100% <ø> (ø)
...s.Azure/Resolvers/AzureBlobStorageCacheResolver.cs 100% <ø> (ø)
....Web.Providers.Azure/SeviceCollectionExtensions.cs 0% <0%> (ø)
...s.Azure/Providers/AzureBlobStorageImageProvider.cs 65% <30%> (-12%) ⬇️
...ders.Azure/Caching/AzureBlobStorageCacheOptions.cs 100% <100%> (ø)
.../Providers/AzureBlobStorageImageProviderOptions.cs 100% <100%> (ø)
...s.Azure/Resolvers/AzureBlobStorageImageResolver.cs 100% <100%> (ø)
.../Synchronization/RefCountedConcurrentDictionary.cs 72% <0%> (-4%) ⬇️
...ching/LruCache/ConcurrentTLruCache{TKey,TValue}.cs 46% <0%> (+2%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

/// <summary>
/// Extension methods for <see cref="IServiceCollection"/> to simplify middleware service registration.
/// </summary>
public static class SeviceCollectionExtensions

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need these extensions. I'd rather we kept the API consistent across all provider types.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Gonna remove that file again. But I think that there is a error on the website.

image

This must be .SetCache<Adblob..>() or am I missing something?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The < > tags were not HTML encoded. Have updated them now thanks.

@JimBobSquarePants JimBobSquarePants merged commit 135c8b1 into SixLabors:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants