Remove nullable disable from azure#309
Merged
JimBobSquarePants merged 3 commits intoMar 6, 2023
Merged
Conversation
* Removed all Nullable disable from the azure providers * Removed IAzureBlobContainerClientOptions because it wasn't used just for declaration * Added convenience DI methods for Adding the cache or image provider. Leaving out the initialization was on purpose to not run that code on startup because it could throw an exception so the app won't start..
28be64d to
11cc34c
Compare
Codecov Report
@@ Coverage Diff @@
## main #309 +/- ##
===================================
- Coverage 85% 85% -1%
===================================
Files 77 78 +1
Lines 2192 2199 +7
Branches 304 308 +4
===================================
- Hits 1879 1877 -2
- Misses 229 235 +6
- Partials 84 87 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| /// <summary> | ||
| /// Extension methods for <see cref="IServiceCollection"/> to simplify middleware service registration. | ||
| /// </summary> | ||
| public static class SeviceCollectionExtensions |
Member
There was a problem hiding this comment.
I don't think we need these extensions. I'd rather we kept the API consistent across all provider types.
Contributor
Author
Member
There was a problem hiding this comment.
The < > tags were not HTML encoded. Have updated them now thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Prerequisites
Description