Skip to content

Drop .NET Core 2.1 to fix Azure dependency security issue#286

Merged
JimBobSquarePants merged 1 commit into
mainfrom
js/azure-security
Aug 11, 2022
Merged

Drop .NET Core 2.1 to fix Azure dependency security issue#286
JimBobSquarePants merged 1 commit into
mainfrom
js/azure-security

Conversation

@JimBobSquarePants

@JimBobSquarePants JimBobSquarePants commented Aug 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

See #284 (Dependabot)

We have a security issue in the Azure Dependency and are unable to upgrade to mitigate the issue without removing support for .NET Core 2.. Since that target framework is long obsolete I've chosen to do this without a major update. The next version will be v2.1.0

@JimBobSquarePants JimBobSquarePants added this to the v2.1.0 milestone Aug 11, 2022
@JimBobSquarePants JimBobSquarePants requested a review from a team August 11, 2022 13:47
@codecov

codecov Bot commented Aug 11, 2022

Copy link
Copy Markdown

Codecov Report

Merging #286 (67f2a67) into main (108a615) will increase coverage by 0%.
The diff coverage is n/a.

@@         Coverage Diff         @@
##           main   #286   +/-   ##
===================================
  Coverage    85%    85%           
===================================
  Files        76     76           
  Lines      2169   2165    -4     
  Branches    303    303           
===================================
- Hits       1855   1853    -2     
+ Misses      229    227    -2     
  Partials     85     85
Flag Coverage Δ
unittests 85% <ø> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ImageSharp.Web/Caching/PhysicalFileSystemCache.cs 98% <ø> (-1%) ⬇️
...arp.Web/ImageSharpRequestAuthorizationUtilities.cs 90% <ø> (ø)
.../ImageSharp.Web/Middleware/ImageSharpMiddleware.cs 80% <ø> (ø)
...eSharp.Web/Providers/PhysicalFileSystemProvider.cs 100% <ø> (ø)
...c/ImageSharp.Web/Providers/WebRootImageProvider.cs 0% <ø> (ø)
.../Synchronization/RefCountedConcurrentDictionary.cs 76% <ø> (+4%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JimBobSquarePants JimBobSquarePants merged commit 7e41144 into main Aug 11, 2022
@JimBobSquarePants JimBobSquarePants deleted the js/azure-security branch August 11, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tocsoft tocsoft tocsoft approved these changes

Assignees

No one assigned

Labels

breaking security

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@JimBobSquarePants @tocsoft