Coverage tool stopped working on newer node versions#79
Closed
niclashedam wants to merge 2 commits intomasterfrom
Closed
Coverage tool stopped working on newer node versions#79niclashedam wants to merge 2 commits intomasterfrom
niclashedam wants to merge 2 commits intomasterfrom
Conversation
Contributor
Author
|
See also nodejs/node#23688 |
Contributor
|
Good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our coverage tool stopped working on some newer versions of node (10.12.0 and later). This issue is possibly related to nodejs/node#22251.
Nonetheless, I have added a replace statement that is triggered if the protocol is prepended to the URL. This fixes the issue and should be backwards-compatible as well :-)