Skip to content

API-7682: Add support for warnings in Events API#112

Merged
advornichenko-sift merged 2 commits into
masterfrom
API-7682-warnings-in-events-api
May 27, 2024
Merged

API-7682: Add support for warnings in Events API#112
advornichenko-sift merged 2 commits into
masterfrom
API-7682-warnings-in-events-api

Conversation

@advornichenko-sift
Copy link
Copy Markdown
Contributor

Purpose

https://sift.atlassian.net/browse/API-7682

Summary

  • if include_warnings is true then add warnings to the fields query parameter.

Testing

  • Added unit test
  • Added integration test

Checklist

  • The change was thoroughly tested manually
  • The change was covered with unit tests
  • The change was tested with real API calls (if applicable)
  • Necessary changes were made in the integration tests (if applicable)
  • New functionality is reflected in README

@advornichenko-sift advornichenko-sift requested review from a team May 24, 2024 11:56
Copy link
Copy Markdown
Contributor

@sbogolii-sift sbogolii-sift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@advornichenko-sift advornichenko-sift merged commit ffc02bd into master May 27, 2024
@advornichenko-sift advornichenko-sift deleted the API-7682-warnings-in-events-api branch May 27, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants