Fixed ToolWindow zoom when in Pan mode#41
Merged
Conversation
Contributor
Author
|
The new line (as in PR) Could be (as But I tested both cases (Pan and ToolWindow as active tools) and they behave as expected - same. So the first option should be good enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the issue when using ZoomWindow in Pan mode
Issue #36
The issue is that, when the
ActiveToolisPanbut we decided to applyToolWindowzoom transform (because Shift modifier is active),_dragEndPointwas not set inMouseMovemethod (because we are in Pan mode).To fix the problem, mouse event positions
e.X, e.Yare used as end point (like in other tools) when mouse click is released.Do not merge this pull request before #40 because it contains both changes
(my bad, previous PR was on master branch instead of a new branch)