This repository was archived by the owner on Dec 24, 2022. It is now read-only.
Revert "Merge pull request #405 from chrisfcarroll/master"#406
Merged
Conversation
mythz
added a commit
that referenced
this pull request
Apr 16, 2014
Revert "Merge pull request #405 from chrisfcarroll/master"
Member
|
ok cool. |
Contributor
Author
|
The difficulty with a proper solution is: CsvSerializer delegates in the end to JsvSerialize.WriteDateTime() which already has some formatting logic driven by JsConfig.DateHandler. So the route I was going we'd end up with the date time format being dependent both on a JsConfig setting and a CsvConfig setting and both settings impacting (I guess) Json serialisation as well as Csv serialisation. |
Member
|
Well it's better to have one configuration for Date Formatting but you can scope it to only be used in CSV with something like: using (JsConfig.With(dateHandler:CsvConfig.DateHandler)) {
...
} |
Contributor
Author
|
Thx, I'll look into that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the commit didn't work and the simplest first step is to revert it.
This reverts commit d9a4e7a, reversing
changes made to 8c32aea.