feat(Dropdown): Adds support for closeOnChange when removing items#4492
feat(Dropdown): Adds support for closeOnChange when removing items#4492stevenrick wants to merge 1 commit intoSemantic-Org:masterfrom
Conversation
|
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4492 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 186 186
Lines 3465 3467 +2
=======================================
+ Hits 3448 3450 +2
Misses 17 17 ☔ View full report in Codecov by Sentry. |
|
one note - i called this a feature, but it could be argued it is actually a bugfix - it's not obvious what the intended purpose of closeOnChange is but I'd argue it should be to close on ANY change (including removal) not just additions, hence this PR |
Fixes #4491
This PR adds support for closeOnChange for item removal via label and backspace in a Multiple Selection Dropdown