[py] Add high-level BiDi network extra headers API#17632
Merged
Conversation
6ebf38f to
81afab8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
Follows #17629 (authentication handlers); final network-module phase of the BiDi Protocol API Design, following #17619 and #17623.
💥 What does this PR do?
Adds the extra-headers API to
driver.network, aligned with the Network Module section of the cross-binding BiDi API design:beforeRequestSentintercept pauses each request and the headers are merged during the registry's reconciliation step — the same singlenetwork.continueRequestcycle that applies user handler mutations, so a request paused by both the extra-headers intercept and user handlers is still continued exactly onceclear_request_handlerslike response/authentication handlers do🔧 Implementation Notes
RequestHandlerRegistryinpy/private/_network_handlers.pywith a small_before_resolvehook in the shared registry base; manifest glue stays thin, matching Phases 1–3🤖 AI assistance
💡 Additional Considerations
continueRequestheader merging)🔄 Types of changes