Better instance not found error messages

aothms · aothms · commit c748c8dcea03 · 2018-04-23T10:51:59.000+02:00
diff --git a/src/ifcparse/IfcParse.cpp b/src/ifcparse/IfcParse.cpp
@@ -1806,15 +1806,15 @@ IfcEntityList::ptr IfcFile::entitiesByReference(int t) {
 IfcUtil::IfcBaseClass* IfcFile::entityById(int id) {
 	entity_by_id_t::const_iterator it = byid.find(id);
 	if (it == byid.end()) {
-		throw IfcException("Entity not found");
+		throw IfcException("Instance #" + boost::lexical_cast<std::string>(id) + " not found");
 	}
 	return it->second;
 }
 
 IfcSchema::IfcRoot* IfcFile::entityByGuid(const std::string& guid) {
 	entity_by_guid_t::const_iterator it = byguid.find(guid);
 	if ( it == byguid.end() ) {
-		throw IfcException("Entity not found");
+		throw IfcException("Instance with GlobalId '" + guid + "' not found");
 	} else {
 		return it->second;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1806,15 +1806,15 @@ IfcEntityList::ptr IfcFile::entitiesByReference(int t) {`
`1806`	`1806`	`IfcUtil::IfcBaseClass* IfcFile::entityById(int id) {`
`1807`	`1807`	`entity_by_id_t::const_iterator it = byid.find(id);`
`1808`	`1808`	`if (it == byid.end()) {`
`1809`		`- throw IfcException("Entity not found");`
	`1809`	`+ throw IfcException("Instance #" + boost::lexical_cast<std::string>(id) + " not found");`
`1810`	`1810`	`}`
`1811`	`1811`	`return it->second;`
`1812`	`1812`	`}`
`1813`	`1813`
`1814`	`1814`	`IfcSchema::IfcRoot* IfcFile::entityByGuid(const std::string& guid) {`
`1815`	`1815`	`entity_by_guid_t::const_iterator it = byguid.find(guid);`
`1816`	`1816`	`if ( it == byguid.end() ) {`
`1817`		`- throw IfcException("Entity not found");`
	`1817`	`+ throw IfcException("Instance with GlobalId '" + guid + "' not found");`
`1818`	`1818`	`} else {`
`1819`	`1819`	`return it->second;`
`1820`	`1820`	`}`