TColgp_SequenceOfPnt::Upper() does not exist on all versions of occt

aothms · aothms · commit 1f68d9d5bcfd · 2018-04-18T11:57:38.000+02:00
diff --git a/src/ifcgeom/IfcGeomWires.cpp b/src/ifcgeom/IfcGeomWires.cpp
@@ -400,7 +400,8 @@ bool IfcGeom::Kernel::convert(const IfcSchema::IfcPolyline* l, TopoDS_Wire& resu
 	const double eps = getValue(GV_PRECISION) * 10;
 	const bool closed_by_proximity = polygon.Length() >= 2 && polygon.First().Distance(polygon.Last()) < eps;
 	if (closed_by_proximity) {
-		polygon.Remove(polygon.Upper());
+		// tfk: note 1-based
+		polygon.Remove(polygon.Length());
 	}
 
 	// Remove points that are too close to one another

Original file line number	Diff line number	Diff line change
`@@ -400,7 +400,8 @@ bool IfcGeom::Kernel::convert(const IfcSchema::IfcPolyline* l, TopoDS_Wire& resu`
`400`	`400`	`const double eps = getValue(GV_PRECISION) * 10;`
`401`	`401`	`const bool closed_by_proximity = polygon.Length() >= 2 && polygon.First().Distance(polygon.Last()) < eps;`
`402`	`402`	`if (closed_by_proximity) {`
`403`		`- polygon.Remove(polygon.Upper());`
	`403`	`+ // tfk: note 1-based`
	`404`	`+ polygon.Remove(polygon.Length());`
`404`	`405`	`}`
`405`	`406`
`406`	`407`	`// Remove points that are too close to one another`