Repository navigation
Fix inverted axis min max span - #4755
Merged
swharden merged 4 commits intoFeb 15, 2025
Merged
Conversation
Fix MinimumSpan handling for inverted axes
Fix MaximumSpan handling for inverted axes
Member
|
Hi @manaruto, thanks so much for this fix! It took me longer than typical to get to this one, but I'm happy to merge it in now and it will be in the next release 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the behavior of MinimumSpan and MaximumSpan rules when an axis is inverted (Min > Max). Previously, these rules did not correctly account for inverted axes, leading to incorrect enforcement of span constraints.
➜ If MinimumSpan or MaximumSpan is used alongside a minimum or maximum boundary, the constraints were not being applied correctly.
➜ If MinimumSpan or MaximumSpan is used alone (without min/max boundary constraints), the axis ticks would not be displayed as inverted.
#4735