Performance optimization, refactoring and revamping.#362
Merged
Conversation
- Added supported_numericals_TF_DataType
- Cleanup and docs to all Tensor.cs files - Changed all uses of System.Convert to NumSharp.Utilities.Converts - Added all missing types in dtypes.cs - Renamed tensor.Data<T> to tensor.ToArray<T>, added obsolete message - Renamed tensor.Data() to tensor.BufferToArray(), added obsolete message - Made GraphKeys to use const string instead allocating strings at every use of GraphKeys.
…Item[] feed_dict)
- Fixed all locations _dtype is used incorrectly.
Oceania2018
approved these changes
Aug 22, 2019
Oceania2018
self-requested a review
August 22, 2019 01:49
Oceania2018
requested changes
Aug 22, 2019
Oceania2018
approved these changes
Aug 22, 2019
Member
Author
|
This memory corruption has been fixed in the PR #366 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
DisposableObject.TensorflowNET.Examples.GPU._FetchHandler: Switched toNPTypeCode(perf-op).gfile.cs, Walk(...): Handle case when directory top doesn't exist.Tensor.Creation: Perf-opted when creating tensor fromNDArrayof dtypestring.Graph.cs: refactor and added docs.Tensor.Explicit.cs: perf-ops.Tensor.Explicit.cs: Added guards for explicit casts.Tensor.csfiles.System.ConverttoNumSharp.Utilities.Converts.dtypes.cs.tensor.Data<T>totensor.ToArray<T>, added obsolete message.tensor.Data()totensor.BufferToArray(), added obsolete message.Tensor.ToArray<T>()andTensor.BufferToArray().GraphKeysto use const string instead allocating strings at everynew GraphKeys()call.Tensor: Added explicit cast to string.Tensor.DisposeUnmanagedResources: Nullify _handle after delete.@Oceania2018, Please review my changes to ensure I did not break something I did not know of.
All unit tests pass. All examples pass (except for those with broken urls)