Skip to content

Added support for NDArray == NDArray and array_equal#263

Merged
Oceania2018 merged 14 commits into
SciSharp:masterfrom
teknologisk-institut:master
May 8, 2019
Merged

Added support for NDArray == NDArray and array_equal#263
Oceania2018 merged 14 commits into
SciSharp:masterfrom
teknologisk-institut:master

Conversation

@katdti
Copy link
Copy Markdown
Contributor

@katdti katdti commented May 8, 2019

Support for comparing NDArray with NDArray using == operator (returning NDArray)
Support for comparing NDArray with NDArray using array_equal (returning bool)
Unit tests for == operator and array_equal added

Add .npy extension if missing when saving files and more unit test added for load/save
arrange function for create a NDArray of type float added

@henon
Copy link
Copy Markdown
Contributor

henon commented May 8, 2019

Hey Karsten,

love your work. You might be interested in this: I added an improved way to test equality of sequences in in test cases helping the developer when something fails.

If deriving the test class from TestClass you get the function AssertAreEqual which gives very helpful error messages if sequences are not equal saying exactly why and where.

Cheers,
-- Henon

SimdEngine.Add is about 20 times slower than Default Engine.Add
@Oceania2018 Oceania2018 requested a review from henon May 8, 2019 13:34
Copy link
Copy Markdown
Contributor

@henon henon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thank you!

@Oceania2018 Oceania2018 merged commit cf8aa9f into SciSharp:master May 8, 2019
@Oceania2018
Copy link
Copy Markdown
Member

@katdti
image

@katdti
Copy link
Copy Markdown
Contributor Author

katdti commented May 10, 2019

SaveAndLoadWithNpyFileExt test works localy on my PC.
Could the probelm be the absolute path C:\temp.... ?
That is the error message?

@Oceania2018
Copy link
Copy Markdown
Member

Should upload the test file to https://github.com/SciSharp/NumSharp/tree/master/test/NumSharp.UnitTest/data, and reference to new file location.

@katdti
Copy link
Copy Markdown
Contributor Author

katdti commented May 10, 2019

It is a temporary file generated during the unit test. I can remove the absolute path and make it relative path as the other unit test uses.

@Oceania2018
Copy link
Copy Markdown
Member

Great, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants