Default version matrix -> Core [lts,1,pre], QA [lts,1]#75
Merged
ChrisRackauckas merged 1 commit intoJun 8, 2026
Merged
Conversation
Align the no-test_groups.toml default in compute_affected_sublibraries.jl with the org version convention: Core (and any standard/default group) on ["lts","1","pre"] and QA on ["lts","1"]. Drops the pinned "1.11" middle version from Core and adds "lts" to QA. GPU is unaffected (it only comes from an explicit test_groups.toml, never the default). Also updates the in-file doc comment and the illustrative test_groups.toml example to the same convention. Monorepo.md and README.md already documented this target default, so no doc edits were needed there. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
that referenced
this pull request
Jun 8, 2026
…-test regression Implements #76: let a monorepo root (or any single package) declare its group x version matrix once in a root test/test_groups.toml and run it via a new reusable grouped-tests.yml, so CI.yml is a thin caller instead of a hand-maintained matrix. - scripts/compute_affected_sublibraries.jl: add a --root-matrix mode that reads <repo>/test/test_groups.toml (no diff filter, no lib/ required) and emits {group, version, runner, timeout, num_threads, continue_on_error}. Adds the continue_on_error per-group field (maps to tests.yml continue-on-error; used for non-fatal groups like OrdinaryDiffEq's Downstream). Default when absent: a single Core group on [lts,1,pre]. - .github/workflows/grouped-tests.yml: new reusable workflow; detect job runs --root-matrix, test job fans out to tests.yml@v1 (project '.') per cell. Mirrors sublibrary-project-tests.yml's proven passthrough. - Additive / backward compatible: existing callers and the sublibrary JSON output are unchanged. - Fix #75 regression: the default-groups test still expected the old [lts,1.11,1,pre]/[1] matrix, so script-tests went red on master after #75; update the expectation and two stale [lts,1.11,1,pre] comments. - Tests: build_root_matrix defaults/fields/continue_on_error, a faithful 46-cell reproduction of OrdinaryDiffEq's embedded root matrix, and a --root-matrix CLI test. README documents the model, grouped-tests.yml, the continue_on_error field, and the new output mode. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the default test version matrix — the one applied when a monorepo sublibrary has no
test/test_groups.toml— with the org version convention.scripts/compute_affected_sublibraries.jldefinesDEFAULT_TEST_GROUPS, whichload_test_groupsfalls back to when a sublibrary ships notest_groups.toml. It was still on the old form. This PR moves it to the standard sets:Core(and any standard/default group)["lts","1.11","1","pre"]["lts","1","pre"]QA["1"]["lts","1"]GPU["1"], only ever set via explicittest_groups.tomlThe pinned
"1.11"middle version is dropped fromCore;QAnow also runs onlts. Only the no-test_groups.tomldefault values change — the dependency-graph / reverse-dep / matrix-emission logic is untouched, and a sublibrary that ships its owntest_groups.tomlis unaffected.Files changed
scripts/compute_affected_sublibraries.jlDEFAULT_TEST_GROUPSconst:Core => ["lts","1","pre"],QA => ["lts","1"].test_groups.tomlexample updated to the same convention.Monorepo.md(§5, "default when there's notest_groups.toml") andREADME.mdalready documented this exact target default, so no doc edits were needed there — this PR brings the script in line with the docs.Validation (static only)
Meta.parseall, 38 top-level forms) — no instantiate / precompile / test run.DEFAULT_TEST_GROUPSliteral verified:Core == ["lts","1","pre"],QA == ["lts","1"], noGPUkey.Ignore until reviewed by @ChrisRackauckas.