Skip to content

SVProgressHUD should support single window apps adopting SceneDelegate#978

Open
slizeray wants to merge 2 commits intoSVProgressHUD:masterfrom
slizeray:master
Open

SVProgressHUD should support single window apps adopting SceneDelegate#978
slizeray wants to merge 2 commits intoSVProgressHUD:masterfrom
slizeray:master

Conversation

@slizeray
Copy link
Copy Markdown

The window property on the app delegate is nil when using a SceneDelegate

…property on the application delegate. It make the lib compatible with apps which adopt the new Scene protocol
Copy link
Copy Markdown

@tanis2000 tanis2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanis2000
Copy link
Copy Markdown

It would be nice to have this merged into a new release

@artem-alexandrov
Copy link
Copy Markdown

Aaaaaand? :) Will it be merged soon?

@binsnoel
Copy link
Copy Markdown

binsnoel commented Oct 5, 2020

when will this be merged? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants