Add nil check in updateViewHierarchy before adding to window#1158
Open
AdrianCurtin wants to merge 3 commits intoSVProgressHUD:masterfrom
Open
Add nil check in updateViewHierarchy before adding to window#1158AdrianCurtin wants to merge 3 commits intoSVProgressHUD:masterfrom
AdrianCurtin wants to merge 3 commits intoSVProgressHUD:masterfrom
Conversation
Added a nil check before calling setNeedsStatusBarAppearanceUpdate on rootViewController to prevent potential crashes when rootViewController is not set.
There was a problem hiding this comment.
Pull request overview
This PR adds defensive nil checks for rootViewController to prevent crashes when SVProgressHUD attempts to add its view to windows or update status bar appearance during app state transitions.
Key Changes:
- Added nil check for
rootViewControllerbefore adding control view to window inupdateViewHierarchy - Added nil check for
rootViewControllerbefore callingsetNeedsStatusBarAppearanceUpdateduring HUD dismissal
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AdrianCurtin
added a commit
to commandpostsoft/SVProgressHUD
that referenced
this pull request
Dec 24, 2025
…ore adding to window
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1157
Adds a nil check for
rootViewControllerbefore adding the control view to the window inupdateViewHierarchy.Problem
When SVProgressHUD is shown, it adds its control view to the front window. If the window exists but has no
rootViewController(or it's in an invalid state during app transitions), UIKit throws anNSInternalInconsistencyExceptionwhen resolving trait collection for the new subview.Solution
Check that
window.rootViewControlleris not nil before adding the subview:Testing