#772 fixed crash when SVG width/height is set to "auto"#773
Open
arturdev wants to merge 1 commit into
Open
Conversation
Contributor
|
The spec seems to say that 'auto' is an illegal value, and that if in doubt, we should be substituting '100%': "If the attribute is not specified, the effect is as if a value of '100%' were specified." ? https://www.w3.org/TR/SVG11/struct.html#SVGElementWidthAttribute |
Contributor
|
(I vaguely remember 'auto' being valid, it's just that a quick skim of the attribs suggest not. Setting it to 100% seems sensible as the fallback though - and seems to be what e.g. chrome is doing when opening the example.svg you provided in the issue report. Can we just get this code to act as 100%?) |
Author
|
Well, this is just a quick workaround for the crash rather than an actual fix till someone who has more knowledge of SVGKit fixes it in the right way :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.