Element add cssstyle#666
Open
lichentao wants to merge 3 commits into
Open
Conversation
adamgit
requested changes
Jan 17, 2020
adamgit
left a comment
Contributor
There was a problem hiding this comment.
-
SVGSVGElement does not extend SVGTransformable -- https://www.w3.org/TR/SVG11/struct.html#InterfaceSVGSVGElement -- that would break the spec
-
styleHasRule is being continuously overwritten. Perhaps this line should be "styleHasRule = styleHasRule | [self ..." ?
-
This appears to duplicate (improve?) the CSS code we already have. If this adds to the existing code, why is it in a new class instead of with the existing CSS classes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
介绍： 通过给style注入css字符串与Element映射
使用方法：1.注入CssStyle样式中添加样式id 或者 class
2.给element vdom 标签设置 id/class