Add ioctl for reading sdb buffer physical address. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

mcarlin-ds wants to merge 7,943 commits into STMicroelectronics:v5.10-stm32mp from DatumSystems:rpmsg-report-physaddr

Closed

Add ioctl for reading sdb buffer physical address. #8

opp: core: fix memory leak in probe deferral

In case of probe deferral, opp debugfs entry is not released which creates
two issues:
- A warning log at each probe attempt:
  "debugfs: Directory 'cpu0' with parent 'opp' already present!"
- A memory leak (seen thank to kmemleak):

root@stm32mp1:~# cat /sys/kernel/debug/kmemleak
unreferenced object 0xde281b40 (size 64):
  comm "kworker/0:1", pid 22, jiffies 4294937523 (age 86.000s)
  hex dump (first 32 bytes):
    24 6e 57 df 24 6e 57 df 10 40 ad df b8 d3 af de  $nW.$nW..@......
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<837aa36f>] _add_opp_dev+0x24/0x38
    [<e0e47c66>] _opp_get_opp_table+0xe8/0x1c8
    [<4ccf360b>] dev_pm_opp_set_supported_hw+0x14/0xa0
    [<b14a10a7>] stm32_cpufreq_probe+0x9c/0x1bc
    [<b7ae2ec8>] platform_drv_probe+0x48/0x98
    [<28167df6>] really_probe+0x24c/0x488
    [<f3f5bbdd>] driver_probe_device+0x78/0x154
    [<0fab043a>] bus_for_each_drv+0x84/0xd0
    [<04d64c2c>] __device_attach+0xe0/0x178
    [<55a4a023>] bus_probe_device+0x84/0x8c
    [<533275e8>] deferred_probe_work_func+0x84/0xc4
    [<f2a58261>] process_one_work+0x1e8/0x588
    [<f2135490>] worker_thread+0x248/0x528
    [<898b4d00>] kthread+0x11c/0x144
    [<4afe9fe2>] ret_from_fork+0x14/0x2c
    [<00000000>] 0x0

Fixes: c4d1d7d ("opp: core: Handle probe deferral for clock")

Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com>
Change-Id: I45b91a140dbff5a7aebd7d7239b9372724c38372
Reviewed-on: https://gerrit.st.com/c/mpu/oe/st/linux-stm32/+/176154
Reviewed-by: Pascal PAILLET <p.paillet@st.com>

Loading branch information

atorgue committed Sep 7, 2020

commit cf1f361a4503ab48352260eab756af6ef52ddd08

drivers/opp/core.c

-Original file line number
+Diff line change
@@ Expand Up @@
     				ret);
     		}
     		else {
+    			mutex_lock(&opp_table->lock);
+    			_remove_opp_dev(opp_dev, opp_table);
     			kfree(opp_table);
+    			mutex_unlock(&opp_table->lock);
     			return ERR_PTR(-EPROBE_DEFER);
     		}
     	}
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ioctl for reading sdb buffer physical address. #8

Uh oh!

Diff view

Diff view

Uh oh!

There are no files selected for viewing