Skip to content

Use JUL logger instead of System.{out,err}.println #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nemonik merged 1 commit into from
Sep 27, 2017
Merged

Use JUL logger instead of System.{out,err}.println #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/main/java/org/mitre/stix/ValidationErrorHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,23 @@
import org.xml.sax.SAXParseException;
import org.xml.sax.SAXException;

import java.util.logging.Logger;

/**
* Parsing and validating error handler
*
* @author nemonik (Michael Joseph Walsh <github.com@nemonik.com>) *
*/
public class ValidationErrorHandler implements ErrorHandler {

private static final Logger LOGGER = Logger.getLogger(ValidationErrorHandler.class.getName());

private void log(String type, SAXParseException e) {
System.err.println("SAXParseException " + type);
System.err.println("\tPublic ID: " + e.getPublicId());
System.err.println("\tSystem ID: " + e.getSystemId());
System.err.println("\tLine : " + e.getLineNumber());
System.err.println("\tColumn : " + e.getColumnNumber());
System.err.println("\tMessage : " + e.getMessage());
LOGGER.warning("SAXParseException " + type);
LOGGER.warning("\tPublic ID: " + e.getPublicId());
LOGGER.warning("\tSystem ID: " + e.getSystemId());
LOGGER.warning("\tLine : " + e.getLineNumber());
LOGGER.warning("\tColumn : " + e.getColumnNumber());
LOGGER.warning("\tMessage : " + e.getMessage());
}

/* (non-Javadoc)
Expand Down Expand Up @@ -50,4 +53,4 @@ public void warning(SAXParseException e) throws SAXException {
log("WARNING", e);
throw e;
}
}
}
29 changes: 16 additions & 13 deletions src/main/java/org/mitre/stix/ValidationEventHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,29 @@
package org.mitre.stix;

import javax.xml.bind.ValidationEvent;
import java.util.logging.Logger;

public class ValidationEventHandler implements javax.xml.bind.ValidationEventHandler {
private static final Logger LOGGER = Logger.getLogger(ValidationErrorHandler.class.getName());

/* (non-Javadoc)
* @see javax.xml.bind.ValidationEventHandler#handleEvent(javax.xml.bind.ValidationEvent)
*/
public boolean handleEvent(ValidationEvent event) {
System.out.println("");
System.out.println("EventT");
System.out.println("\tSeverity: " + event.getSeverity());
System.out.println("\tMessage: " + event.getMessage());
System.out.println("\tLinked Excpetion: " + event.getLinkedException());
System.out.println("\tLocator");
System.out.println("\tLine Number: "
LOGGER.info("");
LOGGER.info("EventT");
LOGGER.info("\tSeverity: " + event.getSeverity());
LOGGER.info("\tMessage: " + event.getMessage());
LOGGER.info("\tLinked Excpetion: " + event.getLinkedException());
LOGGER.info("\tLocator");
LOGGER.info("\tLine Number: "
+ event.getLocator().getLineNumber());
System.out.println("\tColumn Number: "
LOGGER.info("\tColumn Number: "
+ event.getLocator().getColumnNumber());
System.out.println("\tOffset: " + event.getLocator().getOffset());
System.out.println("\tObject: " + event.getLocator().getObject());
System.out.println("\tNode: " + event.getLocator().getNode());
System.out.println("\tURL: " + event.getLocator().getURL());
LOGGER.info("\tOffset: " + event.getLocator().getOffset());
LOGGER.info("\tObject: " + event.getLocator().getObject());
LOGGER.info("\tNode: " + event.getLocator().getNode());
LOGGER.info("\tURL: " + event.getLocator().getURL());
return true;
}
}
}