Support Linux Bluetooth socket addresses - #9243

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

⚙️ Run configuration

• Configuration used: Repository: RustPython/RustPython/.coderabbit.yml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 30983a8a-b1bc-426b-89b6-516ddb8eca51

📥 Commits

Reviewing files that changed from the base of the PR and between 398dd70 and 4b0d5f7.

📒 Files selected for processing: 3

• crates/host_env/src/socket.rs
• crates/host_env/src/socket/bluetooth.rs
• crates/stdlib/src/socket.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

The change adds Linux Bluetooth socket address support for L2CAP, RFCOMM, HCI, and SCO. It adds host-level address conversion and Bluetooth address parsing, then integrates protocol-specific input parsing and output decoding in the standard library.

Changes: Linux Bluetooth socket support

Layer / File(s)	Summary
Bluetooth address model and sockaddr conversion crates/host_env/src/socket.rs, crates/host_env/src/socket/bluetooth.rs	The Linux socket module exposes Bluetooth address types and protocol constants. Address converts to and from socket addresses. Bluetooth address parsing and formatting are also added.
Python address input and sockaddr construction crates/stdlib/src/socket.rs	Linux AF_BLUETOOTH input supports SCO, HCI, L2CAP, and RFCOMM values. The parsed values are converted into Bluetooth socket addresses.
Sockaddr decoding and Python values crates/stdlib/src/socket.rs	Bluetooth socket addresses decode into protocol-specific Python values, including optional L2CAP fields and scalar HCI device IDs when the channel is zero.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant PythonSocket as Python socket API
  participant StdlibSocket as stdlib socket
  participant Bluetooth as host_env Bluetooth

  PythonSocket->>StdlibSocket: Pass AF_BLUETOOTH address to extract_address
  StdlibSocket->>StdlibSocket: Parse protocol-specific input
  StdlibSocket->>Bluetooth: Convert Address to SockAddr
  Bluetooth-->>StdlibSocket: Return SockAddr
  StdlibSocket-->>PythonSocket: Return socket address

  PythonSocket->>StdlibSocket: Decode Bluetooth socket address
  StdlibSocket->>Bluetooth: Parse SockAddr with protocol
  Bluetooth-->>StdlibSocket: Return Address
  StdlibSocket->>StdlibSocket: Format protocol-specific Python value
  StdlibSocket-->>PythonSocket: Return decoded value

Loading

Suggested reviewers: youknowone

The change adds Linux Bluetooth socket address support for L2CAP, RFCOMM, HCI, and SCO with CPython-compatible input and output formats. No outstanding defects were identified, and it appears ready to merge.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: adding Linux Bluetooth socket address support.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

🧪 Generate unit tests (beta)

• Create a new PR

• X
• Mastodon
• Reddit
• LinkedIn