Use sequence repetition for ctypes array types - #9185

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

⚙️ Run configuration

• Configuration used: Repository: RustPython/RustPython/.coderabbit.yml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 47ae5785-df77-45b5-a13e-74378064a23f

📥 Commits

Reviewing files that changed from the base of the PR and between 9f6f771 and 6afdb23.

📒 Files selected for processing: 7

• crates/vm/src/stdlib/_ctypes/array.rs
• crates/vm/src/stdlib/_ctypes/function.rs
• crates/vm/src/stdlib/_ctypes/pointer.rs
• crates/vm/src/stdlib/_ctypes/simple.rs
• crates/vm/src/stdlib/_ctypes/structure.rs
• crates/vm/src/stdlib/_ctypes/union.rs
• extra_tests/snippets/stdlib_ctypes.py

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

ctypes metaclasses now use sequence protocols for type repetition. Array-type creation uses a shared helper that validates lengths and operands. Tests cover repetition across ctypes types, index-based lengths, and reflected multiplication.

Changes: ctypes Sequence Repetition

Layer / File(s)	Summary
Shared array repetition crates/vm/src/stdlib/_ctypes/array.rs	Array types use sequence methods for repetition. The shared helper rejects negative lengths, non-type operands, and lengths above the isize-based limit with the corresponding errors, then calls the cached array-type factory.
Sequence protocol across ctypes metaclasses crates/vm/src/stdlib/_ctypes/function.rs, crates/vm/src/stdlib/_ctypes/pointer.rs, crates/vm/src/stdlib/_ctypes/simple.rs, crates/vm/src/stdlib/_ctypes/structure.rs, crates/vm/src/stdlib/_ctypes/union.rs, extra_tests/snippets/stdlib_ctypes.py	Function-pointer, pointer, simple, structure, and union metaclasses expose the shared sequence methods instead of numeric multiplication methods. Simple-type repetition delegates to the shared array helper. Tests cover both operand orders, index-based lengths, and reflected multiplication.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Suggested reviewers: youknowone

This change makes 8 * ctypes.c_char and ctypes.c_char * 8 both work for ctypes array types, which fixes the Scapy import failure on Windows. No concrete merge-blocking risk was identified, and tests cover both operand orders and reflected multiplication.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 53.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 30 functions across 7 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: replacing numeric multiplication with sequence repetition for ctypes array types. It matches the pull request objectives and changeset.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

🧪 Generate unit tests (beta)

• Create a new PR

• X
• Mastodon
• Reddit
• LinkedIn