Align hashlib and HMAC with Python 3.15 by youknowdot · Pull Request #9170 · RustPython/RustPython

youknowdot · 2026-10-17T01:36:23Z

Summary

Emit the Python 3.15 deprecation warning for the shared native hashlib string= argument, including warning-as-error propagation.
Refresh the complete hashlib and HMAC libraries, their canonical tests, and their shared test helper from CPython 3.15.0 (d220409a13b77de7a6c30abe16ea90db01528edc). This includes SHAKE rejection in HMAC fallback paths and consistent unavailable-algorithm behavior.
Keep this split to six files. The five Python files are exact canonical copies generated through scripts/update_lib; no new test guards, assertion changes, or unrelated support-suite refresh.

Verification

All local gates passed on the unchanged final source:

Full canonical test_hashlib: 88 tests, 15 standard skips; full canonical test_hmac: 146 tests, 46 standard skips. Both ran with -u none; CPU-heavy, bigmem and remote-vector resources were disabled. The normal fast threaded hashing, scrypt, constructor-warning and argument-error cases passed. HMAC's skips also include unavailable _hmac/_sha2 backends.
Direct caller regression test_secrets: 11 tests passed.
Workspace Rust tests (excluding wasm, venvlauncher and CAPI): 1,359 passed.
CAPI tests from crates/capi: 123 passed, 4 existing ignores.
Workspace and CAPI doctests, workspace and CAPI Clippy (--all-targets -- -D warnings), and nonthreading VM compilation passed.
Normal pre-commit hooks passed. All five Python files still match the pinned canonical source byte-for-byte.

Cargo builds and tests used the locked dependency graph, two jobs, disabled incremental compilation, and serialized execution. The release interpreter was built from this source; native test inventories were checked before execution.

Seven other shared-helper consumers retain compatible decorator calls. Their socket/process suites are outside this focused local run. test_support does not use the hashing helper and remains unchanged, preserving its existing RustPython-specific isolation coverage.

Provenance and assistance

This is an independent split from #8954, based directly on main, without taking unrelated recovery changes.

Pinned upstream files: hashlib.py, hmac.py, test_hashlib.py, test_hmac.py, hashlib_helper.py.

AI-assisted by OpenAI Codex (model version unavailable): source comparison, implementation, canonical migration, local verification, and PR preparation.

Warn on the deprecated shared string keyword and refresh the complete hashing libraries, canonical suites, and shared helper from CPython v3.15.0 (d220409a13b77de7a6c30abe16ea90db01528edc) with update_lib. Keep the six-file family independent and add no RustPython test guards. Assisted-by: OpenAI Codex:model version unavailable

coderabbitai · 2026-10-17T01:36:31Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: RustPython/RustPython/.coderabbit.yml
Review profile: CHILL
Plan: Advanced
Run ID: 2f8fb7f6-1f07-464e-87af-d43a9cd46b1c

📥 Commits

Reviewing files that changed from the base of the PR and between 9a16d28 and 45a113b.

⛔ Files ignored due to path filters: 5

Lib/hashlib.py is excluded by !Lib/**
Lib/hmac.py is excluded by !Lib/**
Lib/test/support/hashlib_helper.py is excluded by !Lib/**
Lib/test/test_hashlib.py is excluded by !Lib/**
Lib/test/test_hmac.py is excluded by !Lib/**

📒 Files selected for processing: 1

crates/stdlib/src/hashlib.rs

+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Most software today is very much like an Egyptian pyramid with millions of bricks piled on top of each other, with no structural integrity, but just done by brute force and thousands of slaves. - Alan Kay |
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-17T01:37:33Z

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

:4: SyntaxWarning: invalid decimal literal
:7: SyntaxWarning: "\z" is an invalid escape sequence. Such sequences will not work in the future. Did you mean "\z"? A raw string is also an option.
:10: SyntaxWarning: "\400" is an invalid octal escape sequence. Such sequences will not work in the future. Did you mean "\400"? A raw string is also an option.
:4: SyntaxWarning: invalid decimal literal
:7: SyntaxWarning: "\z" is an invalid escape sequence. Such sequences will not work in the future. Did you mean "\z"? A raw string is also an option.
:10: SyntaxWarning: "\400" is an invalid octal escape sequence. Such sequences will not work in the future. Did you mean "\400"? A raw string is also an option.
:4: SyntaxWarning: invalid decimal literal
:7: SyntaxWarning: "\z" is an invalid escape sequence. Such sequences will not work in the future. Did you mean "\z"? A raw string is also an option.
:10: SyntaxWarning: "\400" is an invalid octal escape sequence. Such sequences will not work in the future. Did you mean "\400"? A raw string is also an option.
[x] lib: cpython/Lib/hashlib.py
[x] test: cpython/Lib/test/test_hashlib.py

dependencies:

hashlib

dependent tests: (147 tests)

[x] lib: cpython/Lib/hmac.py
[x] test: cpython/Lib/test/test_hmac.py

dependencies:

hmac

dependent tests: (9 tests)

hmac: test_hmac test_smtplib
- imaplib: test_imaplib
- multiprocessing.connection:
  - concurrent.futures.process: test_compileall test_concurrent_futures
- secrets: test_secrets
- smtplib: test_smtpnet
  - logging.handlers: test_logging test_pkgutil

Legend:

[+] path exists in CPython
[x] up-to-date, [ ] outdated

chatgpt-codex-connector · 2026-10-17T02:38:40Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-17T02:44:51.276992Z	`45a113b`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 45a113b513

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-17T02:44:49Z

-        self.assertRaises(TypeError, get_builtin_constructor, 3)
+        # ensure that the exception message remains consistent
+        err = re.escape("new() argument 'name' must be str, not int")
+        self.assertRaises(TypeError, err, get_builtin_constructor, 3)


Restore the constructor as the callable under test

When this test runs, assertRaises treats its second argument as the callable, but this changed line passes the regex string err; it therefore catches the resulting 'str' object is not callable TypeError and never executes get_builtin_constructor(3). The test now remains green even if the constructor accepts invalid names, so restore get_builtin_constructor as the second argument.

AGENTS.md reference: AGENTS.md:L276-L282

Useful? React with 👍 / 👎.

youknowone approved these changes Oct 17, 2026

View reviewed changes

youknowone marked this pull request as ready for review October 17, 2026 02:38

youknowone merged commit 5957092 into RustPython:main Oct 17, 2026
22 checks passed

chatgpt-codex-connector Bot reviewed Oct 17, 2026

View reviewed changes

Navigation Menu

Repository navigation

Align hashlib and HMAC with Python 3.15 - #9170

Align hashlib and HMAC with Python 3.15#9170
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:fix/hashlib-hmac-315

youknowdot commented Oct 17, 2026

Uh oh!

coderabbitai Bot commented Oct 17, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 17, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 17, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Oct 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

youknowdot commented Oct 17, 2026

Summary

Verification

Provenance and assistance

Uh oh!

coderabbitai Bot commented Oct 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 17, 2026

📦 Library Dependencies

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Oct 17, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 17, 2026 •

edited

Loading