Skip to content

Remove ucd_3_2_0 feature from rustpython-capi - #9153

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowone:capi-no-ucd-feature
Oct 16, 2026
Merged

Remove ucd_3_2_0 feature from rustpython-capi#9153
youknowone merged 1 commit into
RustPython:mainfrom
youknowone:capi-no-ucd-feature

Conversation

@youknowone

@youknowone youknowone commented Oct 15, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Follow-up to #9011, applying this review comment: capi should not carry its own ucd_3_2_0 feature.

  • Remove the [features] table from crates/capi/Cargo.toml
  • Root ucd_3_2_0 forwards only to rustpython-stdlib?/ucd_3_2_0
  • Drop default-features = false from the workspace rustpython-capi dependency

With --no-default-features --features capi, ucd_3_2_0 is no longer enabled. The default build still enables it through rustpython-stdlib.

AI assistance

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Configuration
    • Updated Unicode compatibility feature handling for the C API integration. The legacy Unicode 3.2.0 option is no longer exposed by the C API crate or forwarded through the workspace dependency configuration. The dependency now uses its standard feature defaults, which may affect builds that relied on the previous feature selection.

@youknowone
Remove ucd_3_2_0 feature from rustpython-capi
92d1b79 
Drop the capi [features] table added in RustPython#9011 along with the root
ucd_3_2_0 forwarding to rustpython-capi and the default-features = false
on the workspace rustpython-capi dependency. The root ucd_3_2_0 feature
still enables rustpython-stdlib/ucd_3_2_0.

Assisted-by: Claude Code:claude-opus-5-5
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T13:25:03.132139Z 92d1b79 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: RustPython/RustPython/.coderabbit.yml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3b1b73e8-ed28-4a9c-a6ff-d49239c96ad2
📥 Commits

Reviewing files that changed from the base of the PR and between a2c11aa and 92d1b79.

📒 Files selected for processing: 2
  • Cargo.toml
  • crates/capi/Cargo.toml
💤 Files with no reviewable changes: 1
  • crates/capi/Cargo.toml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

The Cargo manifests change the ucd_3_2_0 feature forwarding and the default-feature setting for the optional rustpython-capi dependency. The C API manifest no longer declares its own default or ucd_3_2_0 features.

Changes: Cargo feature configuration

Layer / File(s) Summary
Update UCD and C API feature declarations
Cargo.toml, crates/capi/Cargo.toml		 The root ucd_3_2_0 feature no longer forwards to rustpython-capi. The workspace dependency no longer disables default features. The C API manifest removes its default and ucd_3_2_0 feature declarations.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: joshuamegnauth54

Merge Risk: ⚪ Minimal · up to 92d1b

The default build retains UCD 3.2.0 support, while the C API-only no-default configuration does not enable it. No actionable merge-blocking risk remains.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing the ucd_3_2_0 feature from rustpython-capi.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fanninpm

fanninpm commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

cc @bschoenmaeckers

@youknowone
youknowone merged commit 2dbe992 into RustPython:main Oct 16, 2026
21 checks passed
@youknowone
youknowone deleted the capi-no-ucd-feature branch October 16, 2026 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fanninpm fanninpm fanninpm approved these changes
+1 more reviewer
@bschoenmaeckers bschoenmaeckers bschoenmaeckers approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@youknowone @fanninpm @bschoenmaeckers