Skip to content

Update pyo3 to 0.30 - #9152

Merged
youknowone merged 2 commits into
RustPython:mainfrom
bschoenmaeckers:update-pyo3
Oct 15, 2026
Merged

youknowone merged 2 commits into
RustPython:mainfrom
bschoenmaeckers:update-pyo3

Conversation

@bschoenmaeckers

@bschoenmaeckers bschoenmaeckers commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Corrected argument handling when calling Python functions, so standalone functions with a single positional argument are not treated as methods with a self argument.
    • Improved dispatch for variable-argument and fast-call methods while preserving static-method handling.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T13:06:28.719916Z e95a34d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: RustPython/RustPython/.coderabbit.yml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0d38825e-a310-4a29-a33c-86dd874fdaca
📥 Commits

Reviewing files that changed from the base of the PR and between 9014319 and e95a34d.

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing: 4
  • Cargo.toml
  • crates/capi/src/abstract_/iter.rs
  • crates/capi/src/methodobject.rs
  • crates/capi/src/pybuffer.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The workspace dependency changes from PyO3 0.29 to 0.30. C API method-call helpers now receive has_self to determine whether to extract a receiver. Related tests update an import, buffer mutation, and method-call coverage.

Changes: PyO3 update and C API method dispatch

Layer / File(s) Summary
PyO3 0.30 compatibility updates
Cargo.toml, crates/capi/src/abstract_/iter.rs, crates/capi/src/pybuffer.rs
The workspace uses PyO3 0.30. Tests import PySendResult from pyo3::types::iterator and mutate the byte array through as_slice_ptr().
C API method receiver handling
crates/capi/src/methodobject.rs
Dispatch passes has_self to the call helpers, which use it to determine whether to extract a receiver. A test calls a wrapped one-argument Python function without a module.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: youknowone

Merge Risk: ⚪ Minimal · up to e95a3

The reviewed changes show no established regression; the PR appears mergeable subject to normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 3 files. (1 skipped: … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the primary change: updating the workspace pyo3 dependency from 0.29 to 0.30.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 3 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@youknowone
youknowone enabled auto-merge (squash) October 15, 2026 13:03
@youknowone
youknowone merged commit 88f5189 into RustPython:main Oct 15, 2026
27 of 30 checks passed
@fanninpm

Copy link
Copy Markdown
Contributor

@youknowone The Clippy failure is beyond the scope of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants