Repository navigation
Fix update_lib marker preservation for inline classes - #9131
Merged
youknowone merged 2 commits intoOct 15, 2026
Merged
Conversation
Expand canonical inline class suites before appending retained inherited overrides, and validate generated syntax. Run focused migration-tool tests in a path-filtered Python-only CI job. Assisted-by: OpenAI Codex:model version unavailable
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 3
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Keep Rust build gates unchanged and run focused Python migration tests on Linux for tool-only changes. Remove the separate workflow. Assisted-by: OpenAI Codex:model version unavailable
youknowdot
added a commit
to youknowdot/RustPython
that referenced
this pull request
Oct 15, 2026
Rebase the remaining integration onto current main while retaining merged compiler and runtime fixes. Import canonical CPython v3.15.0 library sources through update_lib with preserved RustPython markers and explicit migration deferrals. Include the published dependency-report fix from PR RustPython#8958, partial slot correction from PR RustPython#9127, and update_lib repair with existing-workflow coverage from PR RustPython#9131. Assisted-by: OpenAI Codex:model version unavailable
youknowone
marked this pull request as ready for review
October 15, 2026 04:54
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
youknowdot
added a commit
to youknowdot/RustPython
that referenced
this pull request
Oct 15, 2026
Rebase the remaining integration onto current main while retaining merged compiler and runtime fixes. Import canonical CPython v3.15.0 library sources through update_lib with preserved RustPython markers and explicit migration deferrals. Include the published dependency-report fix from PR RustPython#8958, partial slot correction from PR RustPython#9127, and update_lib repair with existing-workflow coverage from PR RustPython#9131. Assisted-by: OpenAI Codex:model version unavailable
youknowdot
added a commit
to youknowdot/RustPython
that referenced
this pull request
Oct 18, 2026
Rebase the remaining integration onto current main while retaining merged compiler and runtime fixes. Import canonical CPython v3.15.0 library sources through update_lib with preserved RustPython markers and explicit migration deferrals. Include the published dependency-report fix from PR RustPython#8958, partial slot correction from PR RustPython#9127, and update_lib repair with existing-workflow coverage from PR RustPython#9131. Assisted-by: OpenAI Codex:model version unavailable
youknowdot
added a commit
to youknowdot/RustPython
that referenced
this pull request
Oct 18, 2026
Rebase the remaining integration onto current main while retaining merged compiler and runtime fixes. Import canonical CPython v3.15.0 library sources through update_lib with preserved RustPython markers and explicit migration deferrals. Include the published dependency-report fix from PR RustPython#8958, partial slot correction from PR RustPython#9127, and update_lib repair with existing-workflow coverage from PR RustPython#9131. Assisted-by: OpenAI Codex:model version unavailable
youknowdot
added a commit
to youknowdot/RustPython
that referenced
this pull request
Oct 18, 2026
Rebase the remaining integration onto current main while retaining merged compiler and runtime fixes. Import canonical CPython v3.15.0 library sources through update_lib with preserved RustPython markers and explicit migration deferrals. Include the published dependency-report fix from PR RustPython#8958, partial slot correction from PR RustPython#9127, and update_lib repair with existing-workflow coverage from PR RustPython#9131. Assisted-by: OpenAI Codex:model version unavailable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
scripts/update_libpreserving an inherited test marker when CPython defines the destination class with an inline suite, such asclass TestCDecode(TestDecode, CTest): pass. The previous output appended an indented method after that complete statement and produced invalid Python.No
Lib/files are changed. The affected canonical JSON migration stays with the separate Python 3.15 integration work.Validation
PYTHONPATH=scripts python3 -m unittest update_lib.tests.test_patch_spec update_lib.tests.test_migrate -v.ci.yamloffline zizmor comparison: no new findings relative to main (all 15 existing diagnostic signatures unchanged).The existing Linux job uses
.python-versionfor the focused tool-only path; that path does not claim coverage of unrelated update_lib commands. Because this PR itself changesci.yaml, its existing workflow-change filter naturally runs the Rust matrix once. Future tool-only edits do not enable Rust builds. No local Rust build was needed for this Python-tool repair.AI assistance: OpenAI Codex (model version unavailable); reviewed by the contributing maintainer's assistant.