Repository navigation
Update Malachite to 0.14 for standalone example builds - #9118
Conversation
Align the workspace BigInt dependencies with fresh pymath resolution. Update only the Malachite family and its required wide/safe_arch dependencies. Assisted-by: OpenAI Codex:model version unavailable
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
malachite-bigint,malachite-q, andmalachite-baserequirements from 0.13 to 0.14.wide/safe_archupdates, without changing unrelated dependency versions.pymath 0.2.0, which currently selects Malachite 0.14 for its concrete BigInt API.This addresses the
Build example projectsfailure in main CI 38530143046. The root lockfile previously retained 0.13 while the standalone frozen-stdlib example resolved both 0.13 and 0.14, producing incompatible BigInt types. The examples continue resolving their own dependencies; no CI steps or checks are disabled.Dependency review
The published 0.13 and 0.14
malachite-bigintwrapper sources are identical. The rational conversions used by RustPython also have unchanged source. The backend release does contain numerical implementation changes, including FFT multiplication and AVX2/FMA runtime dispatch; this is not claimed to be an implementation-identical upgrade. The new minimum requirements forcewide 1.7.1andsafe_arch 1.2.0. Their MSRVs remain below RustPython's declared Rust 1.99 requirement.Validation
Local Linux validation against baseline
28393e932d46ac4df4e55ff1e393d3f4dc231bac:cargo fmt --all -- --check,git diff --check, and normal configured commit hooks.pymath/ RustPython boundary.cargo build --locked --manifest-path example_projects/barebone/Cargo.tomland the equivalentfrozen_stdlibcommand: both pass. The barebone feature set emits existing VM unused-code warnings.cargo check --locked -p rustpython-vm -p rustpython-stdlib: pass.cargo clippy --locked -p rustpython-common -p rustpython-vm -p rustpython-stdlib --lib: pass without warnings.cargo test --locked -p rustpython-common --lib --no-run, then the produced test executable withint::tests::andfloat_ops::filters: 4 + 7 pass, each filter under a 30-second limit. Existing assertions remain active and unchanged.These are bounded local checks, not a full workspace/C-API/Python suite result. No large-FFT stress, performance, multi-CPU SIMD matrix, macOS, Windows, or WASM runtime validation is claimed. Full upstream CI is pending on the PR.
AI assistance
OpenAI Codex assisted with diagnosis, dependency updates, independent source review, and bounded local validation. The precise model version is not exposed by this runtime. No Python standard-library files or test assertions are modified.
Summary by CodeRabbit