Skip to content

Update Malachite to 0.14 for standalone example builds - #9118

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:fix/malachite-014
Oct 14, 2026
Merged

youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:fix/malachite-014

Conversation

@youknowdot

@youknowdot youknowdot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Update RustPython's workspace malachite-bigint, malachite-q, and malachite-base requirements from 0.13 to 0.14.
  • Refresh the four Malachite lock entries and their required wide / safe_arch updates, without changing unrelated dependency versions.
  • Keep the independently resolved example projects compatible with pymath 0.2.0, which currently selects Malachite 0.14 for its concrete BigInt API.

This addresses the Build example projects failure in main CI 38530143046. The root lockfile previously retained 0.13 while the standalone frozen-stdlib example resolved both 0.13 and 0.14, producing incompatible BigInt types. The examples continue resolving their own dependencies; no CI steps or checks are disabled.

Dependency review

The published 0.13 and 0.14 malachite-bigint wrapper sources are identical. The rational conversions used by RustPython also have unchanged source. The backend release does contain numerical implementation changes, including FFT multiplication and AVX2/FMA runtime dispatch; this is not claimed to be an implementation-identical upgrade. The new minimum requirements force wide 1.7.1 and safe_arch 1.2.0. Their MSRVs remain below RustPython's declared Rust 1.99 requirement.

Validation

Local Linux validation against baseline 28393e932d46ac4df4e55ff1e393d3f4dc231bac:

  • cargo fmt --all -- --check, git diff --check, and normal configured commit hooks.
  • Fresh independent lock resolution for both examples: each selects a single Malachite 0.14 family, including the pymath / RustPython boundary.
  • cargo build --locked --manifest-path example_projects/barebone/Cargo.toml and the equivalent frozen_stdlib command: both pass. The barebone feature set emits existing VM unused-code warnings.
  • Both resulting example executables exit 0 within individual 30-second limits.
  • cargo check --locked -p rustpython-vm -p rustpython-stdlib: pass.
  • cargo clippy --locked -p rustpython-common -p rustpython-vm -p rustpython-stdlib --lib: pass without warnings.
  • cargo test --locked -p rustpython-common --lib --no-run, then the produced test executable with int::tests:: and float_ops:: filters: 4 + 7 pass, each filter under a 30-second limit. Existing assertions remain active and unchanged.

These are bounded local checks, not a full workspace/C-API/Python suite result. No large-FFT stress, performance, multi-CPU SIMD matrix, macOS, Windows, or WASM runtime validation is claimed. Full upstream CI is pending on the PR.

AI assistance

OpenAI Codex assisted with diagnosis, dependency updates, independent source review, and bounded local validation. The precise model version is not exposed by this runtime. No Python standard-library files or test assertions are modified.

Summary by CodeRabbit

  • Chores
    • Updated the versions of three workspace dependencies.

Align the workspace BigInt dependencies with fresh pymath resolution. Update only the Malachite family and its required wide/safe_arch dependencies.

Assisted-by: OpenAI Codex:model version unavailable
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: RustPython/RustPython/.coderabbit.yml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e1be9cd7-f51e-482c-b4e8-0f71fa9cee60
📥 Commits

Reviewing files that changed from the base of the PR and between 0816af6 and fd6aab2.

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing: 1
  • Cargo.toml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

The workspace dependency versions for malachite-bigint, malachite-q, and malachite-base change from 0.13.0 to 0.14.0.

Changes: Malachite dependency update

Layer / File(s) Summary
Update Malachite versions
Cargo.toml
The workspace dependency declarations for malachite-bigint, malachite-q, and malachite-base now use version 0.14.0.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: youknowone

Merge Risk: ⚪ Minimal · up to fd6aa

This update aligns workspace Malachite versions with those selected by standalone examples. The supplied report says those builds passed, and no specific user-impacting regression is established.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the primary change: upgrading Malachite to 0.14 to support standalone example builds.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@youknowone
youknowone marked this pull request as ready for review October 14, 2026 12:40
@youknowone
youknowone enabled auto-merge (squash) October 14, 2026 12:40
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T12:43:06.187663Z fd6aab2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@youknowone
youknowone merged commit b429155 into RustPython:main Oct 14, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants