Repository navigation
Detach Windows multiprocessing socket I/O during blocking calls - #9093
Merged
youknowone merged 1 commit intoOct 13, 2026
Merged
youknowone merged 1 commit into
youknowone merged 1 commit into
Conversation
Snapshot locked send buffers before waiting and preserve the host-captured Winsock error across VM reattachment. Assisted-by: OpenAI Codex: model identifier unavailable
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
youknowdot
added a commit
to youknowdot/RustPython
that referenced
this pull request
Oct 13, 2026
Keep the compiler-only diff unchanged while incorporating the exact source-reviewed RustPython#9093 repair. Assisted-by: OpenAI Codex: model identifier unavailable
youknowone
marked this pull request as ready for review
October 13, 2026 11:47
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detach the VM thread around blocking Windows
_multiprocessing.recvand_multiprocessing.send, following the existing socket I/O convention. These calls currently remain attached while waiting in Winsock, which can prevent stop-the-world collection from completing.io::Errorafter reattachment instead of querying the thread's last error again.This is a shared-main fix found while investigating #9088. The captured Windows stack stops in proxy finalization while waiting for a new manager authentication response. Missing detachment is a source-confirmed hazard consistent with that symptom; the capture does not establish the server's GC state or prove this is the exact cause of that hang.
Validation
One production file; no Lib changes, skips, timeout changes, or test assertion changes.