Skip to content

Restore Python 3.15 TextIOWrapper chunk-size deletion semantics #9082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 1 commit into from
Oct 11, 2026
Merged

Restore Python 3.15 TextIOWrapper chunk-size deletion semantics #9082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions crates/vm/src/stdlib/_io.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3568,17 +3568,6 @@ mod _io {

#[pygetset(setter, name = "_CHUNK_SIZE")]
fn set_chunksize(&self, value: PySetterValue, vm: &VirtualMachine) -> PyResult<()> {
let PySetterValue::Assign(object_value) = value else {
let type_name = self.class().slot_name();
let mut end = type_name.len().min(100);
while !type_name.is_char_boundary(end) {
end -= 1;
}
return Err(vm.new_attribute_error(format!(
"attribute '_CHUNK_SIZE' of '{}' objects cannot be deleted",
&type_name[..end]
)));
};
{
let textio = self.lock(vm)?;
if self.buffer.deref().is_none() {
Expand All @@ -3587,6 +3576,9 @@ mod _io {
drop(textio);
}

let PySetterValue::Assign(object_value) = value else {
return Err(vm.new_attribute_error("cannot delete attribute"));
};
let integer = object_value.try_index(vm)?;

let chunk_size = integer.try_to_primitive::<isize>(vm).map_err(|_| {
Expand Down
17 changes: 8 additions & 9 deletions extra_tests/snippets/stdlib_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,23 +166,22 @@ def __index__(self):
"underlying buffer has been detached",
lambda: setattr(detached_textio, "_CHUNK_SIZE", 16),
)
for wrapper in (textio, uninitialized_textio, detached_textio):
with assert_raises(AttributeError) as error:
for wrapper, error_type, message in (
(textio, AttributeError, "cannot delete attribute"),
(uninitialized_textio, ValueError, "I/O operation on uninitialized object"),
(detached_textio, ValueError, "underlying buffer has been detached"),
):
with assert_raises(error_type) as error:
del wrapper._CHUNK_SIZE
assert str(error.exception) == (
"attribute '_CHUNK_SIZE' of '_io.TextIOWrapper' objects cannot be deleted"
)
assert str(error.exception) == message

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve the existing snippet assertions

AGENTS.md explicitly forbids deleting test lines or modifying assertions, test logic, or test data, but this replacement changes the expected exception type and message for each existing deletion case (and the following hunk also removes the subclass-name expectation). Rework the change without altering these test assertions rather than updating their oracle alongside the implementation.

AGENTS.md reference: AGENTS.md:L274-L275

Useful? React with 👍 / 👎.



for wrapper_name in ("ChunkWrapper", "€" * 34):
wrapper_type = type(wrapper_name, (TextIOWrapper,), {})
wrapper = wrapper_type(BytesIO())
with assert_raises(AttributeError) as error:
del wrapper._CHUNK_SIZE
displayed_name = wrapper_name.encode("utf-8")[:100].decode("utf-8", "ignore")
assert str(error.exception) == (
f"attribute '_CHUNK_SIZE' of '{displayed_name}' objects cannot be deleted"
)
assert str(error.exception) == "cannot delete attribute"
wrapper.close()


Expand Down
Loading