Skip to content

Impl PyBytes_FromString PyBytes_FromObject PyBytes_AsStringAndSize #8795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Sep 23, 2026
Merged

Impl PyBytes_FromString PyBytes_FromObject PyBytes_AsStringAndSize #8795

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
405fbfb
Impl `PyBytes_FromString` `PyBytes_FromObject` `PyBytes_AsStringAndSize`
bschoenmaeckers Sep 23, 2026
5ca1355
Do not copy in PyBytes_FromObject when already a bytes obj
bschoenmaeckers Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 44 additions & 1 deletion crates/capi/src/bytesobject.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use crate::object::define_py_check;
use crate::{PyObject, pystate::with_vm};
use core::ffi::c_char;
use core::ffi::{CStr, c_char, c_int};
use rustpython_vm::builtins::PyBytes;

define_py_check!(fn PyBytes_Check, types.bytes_type);
Expand Down Expand Up @@ -29,6 +29,26 @@ pub unsafe extern "C" fn PyBytes_FromStringAndSize(
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyBytes_FromString(s: *const c_char) -> *mut PyObject {
with_vm(|vm| {
let data = unsafe { CStr::from_ptr(s) }.to_bytes().to_vec();
Ok(vm.ctx.new_bytes(data))
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyBytes_FromObject(obj: *mut PyObject) -> *mut PyObject {
with_vm(|vm| {
let obj = unsafe { &*obj };
if let Some(bytes) = obj.downcast_ref::<PyBytes>() {
Ok(bytes.to_owned())
} else {
obj.try_bytes_like(vm, |bytes| vm.ctx.new_bytes(bytes.to_vec()))
}
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyBytes_Size(bytes: *mut PyObject) -> isize {
with_vm(|vm| {
Expand All @@ -45,6 +65,29 @@ pub unsafe extern "C" fn PyBytes_AsString(bytes: *mut PyObject) -> *mut c_char {
})
}

#[unsafe(no_mangle)]
pub unsafe extern "C" fn PyBytes_AsStringAndSize(
obj: *mut PyObject,
buffer: *mut *mut c_char,
length: *mut isize,
) -> c_int {
with_vm(|vm| {
let data = unsafe { &*obj }.try_downcast_ref::<PyBytes>(vm)?.as_bytes();

if length.is_null() {
if data.contains(&0) {
return Err(vm.new_value_error("embedded null byte"));
}
} else {
unsafe { *length = data.len() as isize };
};

unsafe { *buffer = data.as_ptr().cast_mut().cast() };
Comment thread
bschoenmaeckers marked this conversation as resolved.

Ok(())
})
}

#[cfg(test)]
mod tests {
use pyo3::prelude::*;
Expand Down
Loading