sqlite3: pass None for NULL authorizer args instead of crashing - #8534

#!/bin/bash
set -euo pipefail
rg -n -C 8 \
  'authorizer_callback|set_authorizer|sqlite3_prepare_v2|fn execute\(|fn setlimit\(|fn close\(' \
  crates/stdlib/src/_sqlite3.rs

#!/bin/bash
set -euo pipefail

printf '%s\n' '--- file inventory ---'
git ls-files 'crates/stdlib/src/_sqlite3.rs' 'crates/stdlib/Cargo.toml' 'Cargo.toml'

printf '%s\n' '--- relevant symbols and SQLite calls ---'
rg -n -C 6 \
  'authorizer|set_authorizer|prepare_v2|prepare\(|sqlite3_prepare|sql_limit|db_lock|drop_db|fn close|fn execute|setlimit|set_limit|sqlite3_close' \
  crates/stdlib/src/_sqlite3.rs

printf '%s\n' '--- target sections ---'
sed -n '250,380p' crates/stdlib/src/_sqlite3.rs
sed -n '2740,2840p' crates/stdlib/src/_sqlite3.rs
sed -n '3420,3520p' crates/stdlib/src/_sqlite3.rs

printf '%s\n' '--- raw-handle definitions and ownership ---'
rg -n -C 10 \
  'struct SqliteRaw|enum SqliteRaw|type SqliteRaw|impl .*SqliteRaw|struct Connection|impl Connection|db_lock|drop_db|close_v2|close\(' \
  crates/stdlib/src/_sqlite3.rs

#!/bin/bash
set -euo pipefail

python3 - <<'PY'
from pathlib import Path
p = Path("crates/stdlib/src/_sqlite3.rs")
text = p.read_text()
for needle in ("authorizer", "sqlite3_prepare", "prepare_v2", "db_lock", "drop_db"):
    print(f"{needle}: {text.count(needle)} occurrence(s)")
PY

#!/bin/bash
set -euo pipefail

rg -n -C 8 \
  'authorizer|set_authorizer|prepare_v2|prepare\(|sql_limit|db_lock|drop_db|fn close|fn execute|setlimit|set_limit|sqlite3_close' \
  crates/stdlib/src/_sqlite3.rs

sed -n '2740,2840p' crates/stdlib/src/_sqlite3.rs
sed -n '3420,3520p' crates/stdlib/src/_sqlite3.rs

#!/bin/bash
set -euo pipefail

python3 - <<'PY'
from pathlib import Path
p = Path("crates/stdlib/src/_sqlite3.rs")
lines = p.read_text().splitlines()
terms = ("authorizer", "sqlite3_prepare", "prepare_v2", "db_lock", "drop_db")
for i, line in enumerate(lines, 1):
    if any(term in line for term in terms):
        lo, hi = max(1, i - 8), min(len(lines), i + 12)
        print(f"\n--- lines {lo}-{hi} ---")
        for n in range(lo, hi + 1):
            print(f"{n:5}: {lines[n-1]}")
PY

printf '%s\n' '--- exact file metadata ---'
wc -l crates/stdlib/src/_sqlite3.rs
file crates/stdlib/src/_sqlite3.rs

#!/bin/bash
set -euo pipefail

printf '%s\n' '--- SQLite dependency declarations ---'
rg -n -C 4 'sqlite|libsqlite' Cargo.toml crates/stdlib/Cargo.toml

printf '%s\n' '--- all relevant identifier lines ---'
grep -nE 'authorizer|sqlite3_prepare|prepare_v2|db_lock|drop_db|sqlite3_close' crates/stdlib/src/_sqlite3.rs || true

#!/bin/bash
set -euo pipefail

python3 - <<'PY'
from pathlib import Path
lines = Path("crates/stdlib/src/_sqlite3.rs").read_text().splitlines()
terms = ("authorizer", "sqlite3_prepare", "prepare_v2", "db_lock", "drop_db")
for i, line in enumerate(lines, 1):
    if any(term in line for term in terms):
        print(f"\n--- lines {max(1, i-8)}-{min(len(lines), i+12)} ---")
        for n in range(max(1, i-8), min(len(lines), i+12)+1):
            print(f"{n:5}: {lines[n-1]}")
PY

rg -n -C 4 'sqlite|libsqlite' Cargo.toml crates/stdlib/Cargo.toml || true

#!/bin/bash
set -euo pipefail

python3 - <<'PY'
from pathlib import Path
lines = Path("crates/stdlib/src/_sqlite3.rs").read_text().splitlines()
ranges = [(2860, 2985), (580, 625), (995, 1015), (2790, 2825)]
for lo, hi in ranges:
    print(f"\n--- lines {lo}-{hi} ---")
    for n in range(lo, hi + 1):
        print(f"{n:5}: {lines[n-1]}")
PY

printf '%s\n' '--- ownership traits and close calls ---'
grep -nE 'derive.*Copy|struct Sqlite|impl Drop for Sqlite|sqlite3_close|close_db|drop_db' crates/stdlib/src/_sqlite3.rs || true

#!/bin/bash
set -euo pipefail

python3 - <<'PY'
from pathlib import Path
lines = Path("crates/stdlib/src/_sqlite3.rs").read_text().splitlines()
for lo, hi in ((2860, 2985), (580, 625), (995, 1015), (2790, 2825)):
    print(f"\n--- lines {lo}-{hi} ---")
    for n in range(lo, hi + 1):
        print(f"{n:5}: {lines[n-1]}")
PY

grep -nE 'derive.*Copy|struct Sqlite|impl Drop for Sqlite|sqlite3_close|drop_db' \
  crates/stdlib/src/_sqlite3.rs || true

#!/bin/bash
set -euo pipefail
rg -n -C 10 \
  'struct (Connection|Sqlite|SqliteRaw)|fn drop_db|fn close\(&self|fn prepare\(|sqlite3_close_v2|let raw = ' \
  crates/stdlib/src/_sqlite3.rs

#!/bin/bash
set -euo pipefail
printf '%s\n' '--- file metadata ---'
wc -l crates/stdlib/src/_sqlite3.rs
printf '%s\n' '--- relevant symbols ---'
rg -n -C 12 'drop_db|sqlite3_close_v2|struct Connection|struct Sqlite|struct SqliteRaw|fn prepare|let raw =' crates/stdlib/src/_sqlite3.rs || true
printf '%s\n' '--- target sections ---'
sed -n '2760,2835p' crates/stdlib/src/_sqlite3.rs
sed -n '3440,3525p' crates/stdlib/src/_sqlite3.rs

#!/bin/bash
set -euo pipefail
printf '%s\n' '--- imports and type references ---'
sed -n '1,180p' crates/stdlib/src/_sqlite3.rs
rg -n -C 8 'db_lock|drop_db|close|SqliteRaw|SqliteStatement|sqlite3_close|prepare\\(' crates/stdlib/src/_sqlite3.rs crates -g '*.rs'
printf '%s\n' '--- repository definitions ---'
rg -n -C 10 'struct (Connection|Sqlite|SqliteRaw)|type SqliteRaw|impl (Connection|Sqlite|SqliteRaw)' crates -g '*.rs' || true

#!/bin/bash
set -euo pipefail
printf '%s\n' '--- database lifecycle references ---'
rg -n -C 10 -e 'db_lock' -e 'drop_db' -e 'sqlite3_close' -e 'SqliteRaw' -e 'SqliteStatement' -e 'fn prepare' crates/stdlib/src/_sqlite3.rs crates -g '*.rs' || true
printf '%s\n' '--- candidate type declarations ---'
rg -n -C 10 -e 'struct Connection' -e 'struct Sqlite' -e 'impl Connection' -e 'impl Sqlite' crates -g '*.rs' || true
printf '%s\n' '--- all sqlite3 close/open calls ---'
rg -n -C 6 'sqlite3_(open|close|prepare|finalize)' crates/stdlib/src/_sqlite3.rs crates -g '*.rs' || true

#!/bin/bash
set -euo pipefail
printf '%s\n' '--- connection symbols in target file ---'
rg -n -C 8 '\bConnection\b|\bSqlite\b|\bStatement\b|db_' crates/stdlib/src/_sqlite3.rs | head -n 500
printf '%s\n' '--- module and file inventory ---'
git ls-files '*sqlite*' '*SQLite*'
printf '%s\n' '--- target file structural outline ---'
ast-grep outline crates/stdlib/src/_sqlite3.rs --lang rust | head -n 240

#!/bin/bash
set -u
printf '%s\n' '--- target file paths ---'
git ls-files | grep -i 'sqlite' || true
printf '%s\n' '--- connection and database references ---'
grep -n -E -C 8 'Connection|Sqlite|Statement|db_lock|drop_db|close|prepare' crates/stdlib/src/_sqlite3.rs | head -n 600 || true
printf '%s\n' '--- surrounding type definitions ---'
grep -n -E -C 12 'struct |impl |type ' crates/stdlib/src/_sqlite3.rs | head -n 500 || true

#!/bin/bash
set -u
printf '%s\n' '--- connection and database references ---'
rg -a -n -C 10 -e 'Connection' -e 'Sqlite' -e 'Statement' -e 'db_lock' -e 'drop_db' -e 'sqlite3_close' -e 'prepare' crates/stdlib/src/_sqlite3.rs | head -n 1000 || true
printf '%s\n' '--- target sections with binary mode ---'
sed -n '2700,2840p' crates/stdlib/src/_sqlite3.rs
printf '%s\n' '--- file bytes and embedded NUL locations ---'
python3 - <<'PY'
from pathlib import Path
p = Path("crates/stdlib/src/_sqlite3.rs").read_bytes()
print("bytes", len(p), "nul_bytes", p.count(b"\0"))
print("first_nul", p.find(b"\0"))
PY

#!/bin/bash
set -u
printf '%s\n' '--- SQLite wrapper definitions ---'
grep -a -n -E -C 18 'SqliteRaw|SqliteStatementRaw|struct Sqlite|impl Sqlite|impl SqliteRaw|sqlite3_close_v2|sqlite3_finalize' crates/stdlib/src/_sqlite3.rs | tail -n 900 || true
printf '%s\n' '--- statement wrapper methods ---'
grep -a -n -E -C 14 'fn prepare|fn sql_limit|fn check|fn finalize|fn drop' crates/stdlib/src/_sqlite3.rs | tail -n 900 || true
printf '%s\n' '--- close and preparation call sites ---'
grep -a -n -E -C 18 'drop_db|fn close|Statement::new|raw.prepare|db.prepare' crates/stdlib/src/_sqlite3.rs

#!/bin/bash
set -u
printf '%s\n' '--- authorizer callback and connection lifetime paths ---'
sed -n '560,635p' crates/stdlib/src/_sqlite3.rs
sed -n '995,1055p' crates/stdlib/src/_sqlite3.rs
sed -n '2840,2960p' crates/stdlib/src/_sqlite3.rs
printf '%s\n' '--- standalone SQLite re-entrancy probe ---'
python3 - <<'PY'
import ctypes
import ctypes.util

libname = ctypes.util.find_library("sqlite3")
print("library", libname)
if not libname:
    raise SystemExit("sqlite3 library unavailable")
lib = ctypes.CDLL(libname)

DB = ctypes.c_void_p
STMT = ctypes.c_void_p
AUTH = ctypes.CFUNCTYPE(ctypes.c_int, ctypes.c_void_p, ctypes.c_int,
                        ctypes.c_char_p, ctypes.c_char_p,
                        ctypes.c_char_p, ctypes.c_char_p)

lib.sqlite3_open.argtypes = [ctypes.c_char_p, ctypes.POINTER(DB)]
lib.sqlite3_open.restype = ctypes.c_int
lib.sqlite3_close_v2.argtypes = [DB]
lib.sqlite3_close_v2.restype = ctypes.c_int
lib.sqlite3_set_authorizer.argtypes = [DB, AUTH, ctypes.c_void_p]
lib.sqlite3_set_authorizer.restype = ctypes.c_int
lib.sqlite3_prepare_v2.argtypes = [DB, ctypes.c_char_p, ctypes.c_int,
                                   ctypes.POINTER(STMT), ctypes.POINTER(ctypes.c_char_p)]
lib.sqlite3_prepare_v2.restype = ctypes.c_int
lib.sqlite3_finalize.argtypes = [STMT]
lib.sqlite3_finalize.restype = ctypes.c_int
lib.sqlite3_errmsg.argtypes = [DB]
lib.sqlite3_errmsg.restype = ctypes.c_char_p

db = DB()
rc = lib.sqlite3_open(b":memory:", ctypes.byref(db))
print("open_rc", rc, "db", hex(db.value or 0))
closed = []

def authorizer(_data, _action, _arg1, _arg2, _db_name, _trigger):
    if not closed:
        close_rc = lib.sqlite3_close_v2(db)
        closed.append(close_rc)
        print("close_v2_in_callback_rc", close_rc)
    return 0

authorizer_cb = AUTH(authorizer)
set_rc = lib.sqlite3_set_authorizer(db, authorizer_cb, None)
print("set_authorizer_rc", set_rc)
stmt = STMT()
tail = ctypes.c_char_p()
try:
    prep_rc = lib.sqlite3_prepare_v2(
        db, b"CREATE TABLE t(x)", -1, ctypes.byref(stmt), ctypes.byref(tail)
    )
    print("prepare_rc", prep_rc, "stmt", hex(stmt.value or 0),
          "close_results", closed)
    if prep_rc == 0 and stmt:
        print("finalize_rc", lib.sqlite3_finalize(stmt))
finally:
    # Do not call close again if the callback already closed the handle.
    pass
PY

#!/bin/bash
set -u
printf '%s\n' '--- SQLite close contract ---'
curl -L --fail --silent https://sqlite.org/c3ref/close.html | sed -n '1,220p' || true
printf '%s\n' '--- SQLite threading contract ---'
curl -L --fail --silent https://sqlite.org/threadsafe.html | sed -n '1,220p' || true
printf '%s\n' '--- local tests for cross-thread connections and authorizers ---'
rg -n -C 8 'check_same_thread|set_authorizer|authorizer|close\(' Lib/test/test_sqlite3 crates/stdlib/src/_sqlite3.rs | head -n 500 || true