-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix future annotation block alignment #8506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
youknowone
merged 1 commit into
RustPython:main
from
youknowone:agent/consume-unannotated-annotation-block
Aug 12, 2026
+27
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 1082
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 38783
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 50377
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 21710
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 339
🏁 Script executed:
Repository: RustPython/RustPython
Length of output: 399
Consume hidden annotation blocks for skipped unannotated functions.
consume_function_annotation_symbol_table_if_usedreturns without advancing whenannotations_usedis false. Under future annotations, every function still has a hiddenAnnotationBlock. A skipped handler function can therefore leave its block current, causing a later annotated function inorelseto consume the wrong block. Advance the block for both used and unused annotations, while retaining the missing-table error for used blocks.🤖 Prompt for AI Agents