Skip to content

Fix a few WASI lints - #8457

Open
joshuamegnauth54 wants to merge 1 commit into
RustPython:mainfrom
joshuamegnauth54:fix-wasi-lints
Open

Fix a few WASI lints#8457
joshuamegnauth54 wants to merge 1 commit into
RustPython:mainfrom
joshuamegnauth54:fix-wasi-lints

Conversation

@joshuamegnauth54

@joshuamegnauth54 joshuamegnauth54 commented Aug 6, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

I left one lint (a clippy deny) unfixed because it's a lot more involved, so I'll work on it in a different patch.

Summary

Summary by CodeRabbit

  • Refactor

    • Streamlined internal garbage-collection timing handling without changing runtime behavior.
    • Modernized internal error-message formatting while preserving existing errors.

  • Chores

    • Improved cross-platform code quality checks and lint handling.
    • Maintained consistent behavior for signal handling, time formatting, and execution across supported platforms.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 33eb0ed3-4593-43ac-a6ed-365a8664a294

📥 Commits

Reviewing files that changed from the base of the PR and between 1c7759c and b5692ba.

📒 Files selected for processing (5)
  • crates/vm/src/frame.rs
  • crates/vm/src/gc_state.rs
  • crates/vm/src/stdlib/_signal.rs
  • crates/vm/src/stdlib/posix_compat.rs
  • crates/vm/src/stdlib/time.rs
🚧 Files skipped from review as they are similar to previous changes (5)
  • crates/vm/src/frame.rs
  • crates/vm/src/stdlib/posix_compat.rs
  • crates/vm/src/stdlib/time.rs
  • crates/vm/src/stdlib/_signal.rs
  • crates/vm/src/gc_state.rs
📝 Walkthrough

Walkthrough

The PR adds platform-specific Clippy expectations, changes GC timing arguments to pass by value, and updates one format string to use captured argument syntax.

Changes

VM lint and helper cleanup

Layer / File(s) Summary
Platform-specific Clippy expectations
crates/vm/src/frame.rs, crates/vm/src/stdlib/_signal.rs, crates/vm/src/stdlib/time.rs		 Adds conditional Clippy expectations for platform-dependent code paths.
GC duration helper ownership
crates/vm/src/gc_state.rs		 Changes elapsed_secs and all collection-duration call sites to pass start_time by value.
Captured format argument
crates/vm/src/stdlib/posix_compat.rs		 Updates os_unimpl to use the captured {func} format argument.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: youknowone, shaharnaveh

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the pull request's primary change: fixing several WASI-related lints.
Docstring Coverage ✅ Passed Docstring coverage is 88.89% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@joshuamegnauth54
Fix a few WASI lints
b5692ba 
I left one lint (a clippy deny) unfixed because it's a lot more
involved, so I'll work on it in a different patch.
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@joshuamegnauth54