Skip to content

Use datastack path for __init__ dispatch in CallAllocAndEnterInit #8448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 1 commit into from
Aug 3, 2026
+2 −5
Merged

Use datastack path for __init__ dispatch in CallAllocAndEnterInit #8448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/vm/src/builtins/function.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,7 +791,7 @@ impl Py<PyFunction> {
frame
}

fn invoke_prepared_exact_args(
pub(crate) fn invoke_prepared_exact_args(
&self,
args: impl ExactSizeIterator<Item = PyObjectRef>,
vm: &VirtualMachine,
Comment on lines +794 to 797
Expand Down
5 changes: 1 addition & 4 deletions crates/vm/src/frame.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2673,10 +2673,7 @@ impl ExecutingFrame<'_> {
.iter_mut()
.map(|slot| slot.take().expect("arg slot must be filled"));

let init_frame = init_func.prepare_exact_args_frame(taken, vm);
let init_result = vm.run_frame(init_frame.clone());
release_datastack_frame(&init_frame, vm);
let init_result = init_result?;
let init_result = init_func.invoke_prepared_exact_args(taken, vm)?;

if !vm.is_none(&init_result) {
return Err(vm.new_type_error(format!(
Expand Down
Loading