Skip to content

Rebase range iterator __reduce__ to match CPython #8424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devyubin wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

Rebase range iterator __reduce__ to match CPython #8424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/vm/src/builtins/range.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,13 +716,17 @@ fn range_iter_reduce(
vm: &VirtualMachine,
) -> PyTupleRef {
let iter = builtins_iter(vm);
// CPython pickles the remaining range with a None state. next() increments
// the index unconditionally, so clamp it to length before rebasing start.
let index = BigInt::from(index).min(length.clone());
let stop = start.clone() + length * step.clone();
let start = start + index * step.clone();
let range = PyRange {
start: PyInt::from(start).into_ref(&vm.ctx),
stop: PyInt::from(stop).into_ref(&vm.ctx),
step: PyInt::from(step).into_ref(&vm.ctx),
};
vm.new_tuple((iter, (range,), index))
vm.new_tuple((iter, (range,), vm.ctx.none()))
}

// Silently clips state (i.e index) in range [0, usize::MAX].
Expand Down
Loading