csv: validate dialect options - #8402

#!/bin/bash
set -euo pipefail

repo="RustPython/RustPython"
pr_number="8402"
review_id="4788540642"

echo "== Review =="
gh api "repos/$repo/pulls/$pr_number/reviews/$review_id" \
  --jq '{id, user: .user.login, state, body, submitted_at, commit_id}'

echo
echo "== Inline comments in review =="
gh api --paginate "repos/$repo/pulls/$pr_number/comments?per_page=100" \
  --jq ".[] | select(.pull_request_review_id == $review_id) | {id, path, line, side, body, html_url}"

#!/bin/bash
set -euo pipefail

repo="RustPython/RustPython"
pr_number="8402"
review_id="4788540642"

gh api --paginate "repos/$repo/pulls/$pr_number/comments?per_page=100" \
  --jq ".[] | select(.pull_request_review_id == $review_id and .user.login == \"coderabbitai\") | {id, path, line, side, body, html_url}"

#!/bin/bash
set -euo pipefail

repo="RustPython/RustPython"
review_id="4788540642"

gh api --paginate "repos/$repo/pulls/reviews/$review_id/comments?per_page=100" \
  --jq '.[] | {id, user: .user.login, path, line, side, body, html_url}'

#!/bin/bash
set -euo pipefail

repo="RustPython/RustPython"
pr_number="8402"
review_id="4788540642"

gh api "repos/$repo/pulls/$pr_number/reviews/$review_id" \
  --jq '{id, user: .user.login, state, body, submitted_at, commit_id, html_url}'

#!/bin/bash
set -euo pipefail

repo="RustPython/RustPython"
pr_number="8402"
review_id="4788540642"
body_file="$(mktemp)"
updated_body_file="$(mktemp)"
trap 'rm -f "$body_file" "$updated_body_file"' EXIT

gh api "repos/$repo/pulls/$pr_number/reviews/$review_id" --jq '.body' > "$body_file"

python3 - "$body_file" "$updated_body_file" <<'PY'
from pathlib import Path
import sys

source = Path(sys.argv[1]).read_text()
old_finding = """**Use the dialect attribute validation helpers for `escapechar` and `quotechar` kwargs.**

The `delimiter` kwarg already delegates to `parse_delimiter_from_obj`. `escapechar`/`quotechar` should use the corresponding helpers instead of inlining checks, so invalid types/lengths use the correct `TypeError` text and accept `PyNone` where that helper supports it. This closes the remaining keyword-argument path for issue `#8284`."""
new_finding = """**Support `escapechar=None` as a keyword override.**

The string validation is now correct. However, the `escapechar` keyword branch rejects `None`, while a dialect attribute accepts it. Also, `FormatOptions::escapechar: Option<u8>` cannot represent an explicit `None` override that clears an `escapechar` inherited from a base dialect. Change it to represent three states: omitted, a character, and explicit `None`. Keep `quotechar` behavior unchanged because `Option<Option<u8>>` already represents these states."""

old_prompt = """In `@crates/stdlib/src/csv.rs` around lines 632 - 757, Update
FormatOptions::from_args to parse the escapechar and quotechar kwargs through
the existing dialect attribute validation helpers, matching the delimiter path.
Remove the inline match-based validation and preserve each helper’s handling of
invalid types, character length, and PyNone support."""
new_prompt = """In `@crates/stdlib/src/csv.rs` around lines 632 - 757, Update
FormatOptions so the `escapechar` keyword accepts `None` and can explicitly
clear an `escapechar` inherited from a base dialect. Use a representation that
distinguishes an omitted keyword, a one-character string, and explicit `None`.
Keep the existing single-character validation. Do not change `quotechar`
handling because it already distinguishes these states."""

if source.count(old_finding) != 1 or source.count(old_prompt) != 2:
    raise SystemExit("The expected review text was not found in the expected count.")

updated = source.replace(old_finding, new_finding).replace(old_prompt, new_prompt)
Path(sys.argv[2]).write_text(updated)
PY

gh api \
  --method PATCH \
  "repos/$repo/pulls/$pr_number/reviews/$review_id" \
  --raw-field "body=$(cat "$updated_body_file")" \
  --jq '{id, state, html_url}'

#!/bin/bash
set -euo pipefail

repo="RustPython/RustPython"
pr_number="8402"
review_id="4788540642"
body_file="$(mktemp)"
trap 'rm -f "$body_file"' EXIT

gh api "repos/$repo/pulls/$pr_number/reviews/$review_id" --jq '.body' > "$body_file"

rg -n -C 4 'Use the dialect attribute|FormatOptions::from_args|escapechar and quotechar|escapechar kwargs' "$body_file"

#!/bin/bash
set -euo pipefail

repo="RustPython/RustPython"
pr_number="8402"
review_id="4788540642"
body_file="$(mktemp)"
updated_body_file="$(mktemp)"
trap 'rm -f "$body_file" "$updated_body_file"' EXIT

gh api "repos/$repo/pulls/$pr_number/reviews/$review_id" --jq '.body' > "$body_file"

python3 - "$body_file" "$updated_body_file" <<'PY'
from pathlib import Path
import sys

source = Path(sys.argv[1]).read_text()

replacements = {
"""**Use the dialect attribute validation helpers for `escapechar` and `quotechar` kwargs.**

The `delimiter` kwarg already delegates to `parse_delimiter_from_obj`. `escapechar`/`quotechar` should use the corresponding helpers instead of inlining checks, so invalid types/lengths use the correct `TypeError` text and accept `PyNone` where that helper supports it. This closes the remaining keyword-argument path for issue `#8284`."""
:
"""**Support `escapechar=None` as a keyword override.**

The string validation is now correct. However, the `escapechar` keyword branch rejects `None`, while a dialect attribute accepts it. Also, `FormatOptions::escapechar: Option<u8>` cannot represent an explicit `None` override that clears an `escapechar` inherited from a base dialect. Change it to represent omitted, character, and explicit-`None` states. Keep `quotechar` behavior unchanged because `Option<Option<u8>>` already represents these states."""
,
"""In `@crates/stdlib/src/csv.rs` around lines 632 - 757, Update
FormatOptions::from_args to parse the escapechar and quotechar kwargs through
the existing dialect attribute validation helpers, matching the delimiter path.
Remove the inline match-based validation and preserve each helper’s handling of
invalid types, character length, and PyNone support."""
:
"""In `@crates/stdlib/src/csv.rs` around lines 632 - 757, Update
FormatOptions so the `escapechar` keyword accepts `None` and can explicitly
clear an `escapechar` inherited from a base dialect. Use a representation that
distinguishes an omitted keyword, a one-character string, and explicit `None`.
Keep the existing single-character validation. Do not change `quotechar`
handling because it already distinguishes these states."""
,
"""- Around line 632-757: Update FormatOptions::from_args to parse the escapechar
and quotechar kwargs through the existing dialect attribute validation helpers,
matching the delimiter path. Remove the inline match-based validation and
preserve each helper’s handling of invalid types, character length, and PyNone
support."""
:
"""- Around line 632-757: Update FormatOptions so the `escapechar` keyword
accepts `None` and can explicitly clear an inherited `escapechar`. Use a
representation that distinguishes an omitted keyword, a one-character string,
and explicit `None`. Keep the existing single-character validation. Do not
change `quotechar` handling because it already distinguishes these states."""
}

updated = source
for old, new in replacements.items():
    count = updated.count(old)
    if count != 1:
        raise SystemExit(f"Expected exactly one occurrence, found {count}: {old[:72]!r}")
    updated = updated.replace(old, new)

Path(sys.argv[2]).write_text(updated)
PY

gh api \
  --method PATCH \
  "repos/$repo/pulls/$pr_number/reviews/$review_id" \
  --raw-field "body=$(cat "$updated_body_file")" \
  --jq '{id, state, html_url}'

#!/bin/bash
set -euo pipefail

repo="RustPython/RustPython"
pr_number="8402"
review_id="4788540642"
body_file="$(mktemp)"
trap 'rm -f "$body_file"' EXIT

gh api "repos/$repo/pulls/$pr_number/reviews/$review_id" --jq '.body' > "$body_file"

sed -n '41,59p;99,104p' "$body_file" | cat -vet

#!/bin/bash
set -euo pipefail

repo="RustPython/RustPython"
pr_number="8402"
review_id="4788540642"
body_file="$(mktemp)"
updated_body_file="$(mktemp)"
trap 'rm -f "$body_file" "$updated_body_file"' EXIT

gh api "repos/$repo/pulls/$pr_number/reviews/$review_id" --jq '.body' > "$body_file"

python3 - "$body_file" "$updated_body_file" <<'PY'
from pathlib import Path
import sys

source = Path(sys.argv[1]).read_text()

replacements = {
"""> **Use the dialect attribute validation helpers for `escapechar` and `quotechar` kwargs.**
> 
> The `delimiter` kwarg already delegates to `parse_delimiter_from_obj`. `escapechar`/`quotechar` should use the corresponding helpers instead of inlining checks, so invalid types/lengths use the correct `TypeError` text and accept `PyNone` where that helper supports it. This closes the remaining keyword-argument path for issue `#8284`."""
:
"""> **Support `escapechar=None` as a keyword override.**
> 
> The string validation is now correct. However, the `escapechar` keyword branch rejects `None`, while a dialect attribute accepts it. Also, `FormatOptions::escapechar: Option<u8>` cannot represent an explicit `None` override that clears an `escapechar` inherited from a base dialect. Change it to represent omitted, character, and explicit-`None` states. Keep `quotechar` behavior unchanged because `Option<Option<u8>>` already represents these states."""
,
"""> In `@crates/stdlib/src/csv.rs` around lines 632 - 757, Update
> FormatOptions::from_args to parse the escapechar and quotechar kwargs through
> the existing dialect attribute validation helpers, matching the delimiter path.
> Remove the inline match-based validation and preserve each helper’s handling of
> invalid types, character length, and PyNone support."""
:
"""> In `@crates/stdlib/src/csv.rs` around lines 632 - 757, Update
> FormatOptions so the `escapechar` keyword accepts `None` and can explicitly
> clear an `escapechar` inherited from a base dialect. Use a representation that
> distinguishes an omitted keyword, a one-character string, and explicit `None`.
> Keep the existing single-character validation. Do not change `quotechar`
> handling because it already distinguishes these states."""
,
"""- Around line 632-757: Update FormatOptions::from_args to parse the escapechar
and quotechar kwargs through the existing dialect attribute validation helpers,
matching the delimiter path. Remove the inline match-based validation and
preserve each helper’s handling of invalid types, character length, and PyNone
support."""
:
"""- Around line 632-757: Update FormatOptions so the `escapechar` keyword
accepts `None` and can explicitly clear an inherited `escapechar`. Use a
representation that distinguishes an omitted keyword, a one-character string,
and explicit `None`. Keep the existing single-character validation. Do not
change `quotechar` handling because it already distinguishes these states."""
}

updated = source
for old, new in replacements.items():
    count = updated.count(old)
    if count != 1:
        raise SystemExit(f"Expected exactly one occurrence, found {count}: {old[:72]!r}")
    updated = updated.replace(old, new)

Path(sys.argv[2]).write_text(updated)
PY

gh api \
  --method PATCH \
  "repos/$repo/pulls/$pr_number/reviews/$review_id" \
  --raw-field "body=$(cat "$updated_body_file")" \
  --jq '{id, state, html_url}'

#!/bin/bash
set -euo pipefail

gh api \
  "repos/RustPython/RustPython/pulls/8402/comments?per_page=100" \
  --paginate \
  --jq '.[] | select(.id == 3722348588) | {id, body, path, line, original_line, in_reply_to_id, user: .user.login}'

#!/bin/bash
set -euo pipefail

echo '=== Matching review comments ==='
gh api \
  "repos/RustPython/RustPython/pulls/8402/comments?per_page=100" \
  --paginate \
  --jq '.[] | select((.body | test("Configure csv-core from the resolved dialect|resolved dialect|csv-core"; "i")) or (.user.login == "coderabbitai")) | {id, body, path, line, original_line, in_reply_to_id, user: .user.login}'

echo '=== Current writer construction and csv-core configuration ==='
ast-grep outline crates/stdlib/src/csv.rs --items all --type function --match 'writer|to_writer|result' --view expanded
sed -n '470,510p;800,930p' crates/stdlib/src/csv.rs

#!/bin/bash
set -euo pipefail

repo="RustPython/RustPython"
pr="8402"

gh api --paginate "repos/${repo}/pulls/${pr}/comments?per_page=100" \
  --jq '.[] | select(.user.login == "coderabbitai" or (.body | test("WTF-8|WTF8|Wtf8"; "i"))) | {
    id,
    node_id,
    path,
    line,
    original_line,
    body,
    html_url,
    user: .user.login
  }'

#!/bin/bash
set -euo pipefail

gh api graphql \
  -F owner="RustPython" \
  -F name="RustPython" \
  -F number=8402 \
  -f query='
query($owner: String!, $name: String!, $number: Int!) {
  repository(owner: $owner, name: $name) {
    pullRequest(number: $number) {
      reviewThreads(first: 100) {
        nodes {
          isResolved
          isOutdated
          path
          line
          originalLine
          comments(first: 100) {
            nodes {
              databaseId
              author { login }
              body
              url
              createdAt
            }
          }
        }
      }
    }
  }
}' \
  --jq '
    .data.repository.pullRequest.reviewThreads.nodes[]
    | select(any(.comments.nodes[]; .databaseId == 3722375710))
  '