-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Reduce Python→Python call overhead with LightFrame #8354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
youknowone
wants to merge
4
commits into
RustPython:main
Choose a base branch
from
youknowone:light-frame-call-overhead
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+745
−84
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7d65510
Add LightFrame for unobserved Python-to-Python calls
youknowone a2e4f99
Streamline with_frame: inline recursion check, skip tracing dispatch
youknowone 2ce0404
Address review findings for LightFrame correctness
youknowone 2ed7ca5
Fix CI failures: cspell, stale materialized state, f_back chain gaps
youknowone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coderabbitai can this be confirmed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 46644
🏁 Script executed:
Length of output: 20133
@fanninpm, confirmed.PyAtomic<u32>is feature-dependent incrates/common/src/atomic.rs:threading:AtomicU32threading:core::cell::Cell<u32>But
LightFrame::lastiis unconditionally declared ascore::sync::atomic::AtomicU32(incrates/vm/src/frame.rs, Line 72), then cast to&PyAtomic<u32>in the new call path. The wasm package explicitly builds the VM without thethreadingfeature, so that cast becomes effectively:That is unsound. A matching size/alignment today would not make it valid: the types have no guaranteed layout equivalence, and
Celloperations perform interior mutation through a reference that does not actually point to aCell.The appropriate fix is to make
LightFrame::lastiaPyAtomic<u32>, initialize it withRadium::new(0), and pass&(*light).lastidirectly—removing the cast entirely.One wording refinement: the unsafe raw-pointer cast likely bypasses a normal compile-time type mismatch, so I can confirm the non-threading unsoundness rather than specifically a guaranteed build failure.