Skip to content

Implement termios.tcgetwinsize/tcsetwinsize #8347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sigmaith wants to merge 5 commits into
base: main
Choose a base branch
from
+48 −4
Draft

Implement termios.tcgetwinsize/tcsetwinsize #8347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d09e9b8
Implement termios.tcgetwinsize/tcsetwinsize
sigmaith Jul 22, 2026
0614732
Use ret < 0 convention for ioctl error checks in termios winsize
sigmaith Jul 22, 2026
2c555e5
Reject non-sequence size in tcsetwinsize
sigmaith Jul 22, 2026
414a869
Use `core::mem::zeroed` instead of `std::mem::zeroed`
sigmaith Jul 22, 2026
8af3f22
Use try_index for tcsetwinsize row/col conversion
sigmaith Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Lib/test/test_termios.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@ def writer():
'output was not resumed')
self.assertEqual(os.read(rfd, 1024), b'def')

@unittest.expectedFailure # TODO: RUSTPYTHON; AttributeError: module 'termios' has no attribute 'tcgetwinsize'
def test_tcgetwinsize(self):
size = termios.tcgetwinsize(self.fd)
self.assertIsInstance(size, tuple)
Expand All @@ -230,22 +229,19 @@ def test_tcgetwinsize(self):
self.assertIsInstance(size[1], int)
self.assertEqual(termios.tcgetwinsize(self.stream), size)

@unittest.expectedFailure # TODO: RUSTPYTHON; AttributeError: module 'termios' has no attribute 'tcgetwinsize'
def test_tcgetwinsize_errors(self):
self.assertRaisesTermiosError(errno.ENOTTY, termios.tcgetwinsize, self.bad_fd)
self.assertRaises(ValueError, termios.tcgetwinsize, -1)
self.assertRaises(OverflowError, termios.tcgetwinsize, 2**1000)
self.assertRaises(TypeError, termios.tcgetwinsize, object())
self.assertRaises(TypeError, termios.tcgetwinsize)

@unittest.expectedFailure # TODO: RUSTPYTHON; AttributeError: module 'termios' has no attribute 'tcgetwinsize'
def test_tcsetwinsize(self):
size = termios.tcgetwinsize(self.fd)
termios.tcsetwinsize(self.fd, size)
termios.tcsetwinsize(self.fd, list(size))
termios.tcsetwinsize(self.stream, size)

@unittest.expectedFailure # TODO: RUSTPYTHON; AttributeError: module 'termios' has no attribute 'tcgetwinsize'
def test_tcsetwinsize_errors(self):
size = termios.tcgetwinsize(self.fd)
self.assertRaises(TypeError, termios.tcsetwinsize, self.fd, size[:-1])
Expand Down
24 changes: 24 additions & 0 deletions crates/host_env/src/termios.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,3 +165,27 @@ pub fn tcflush(fd: i32, queue: i32) -> std::io::Result<()> {
pub fn tcflow(fd: i32, action: i32) -> std::io::Result<()> {
::termios::tcflow(fd, action)
}

pub fn tcgetwinsize(fd: i32) -> std::io::Result<(u16, u16)> {
let mut size: libc::winsize = unsafe { core::mem::zeroed() };
let ret = unsafe { libc::ioctl(fd, TIOCGWINSZ as _, &mut size) };
if ret < 0 {
return Err(std::io::Error::last_os_error());
}
Ok((size.ws_row, size.ws_col))
}

pub fn tcsetwinsize(fd: i32, row: u16, col: u16) -> std::io::Result<()> {
let mut size: libc::winsize = unsafe { core::mem::zeroed() };
let ret = unsafe { libc::ioctl(fd, TIOCGWINSZ as _, &mut size) };
if ret < 0 {
return Err(std::io::Error::last_os_error());
}
size.ws_row = row;
size.ws_col = col;
let ret = unsafe { libc::ioctl(fd, TIOCSWINSZ as _, &size) };
if ret < 0 {
return Err(std::io::Error::last_os_error());
}
Ok(())
}
24 changes: 24 additions & 0 deletions crates/stdlib/src/termios.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,30 @@ mod termios {
Ok(())
}

#[pyfunction]
fn tcgetwinsize(fd: PyObjectRef, vm: &VirtualMachine) -> PyResult<(u16, u16)> {
let fd = Fildes::try_from_object(vm, fd).map(Into::into)?;
let size = host_termios::tcgetwinsize(fd).map_err(|e| termios_error(e, vm))?;
Ok(size)
}

#[pyfunction]
fn tcsetwinsize(fd: PyObjectRef, size: PyObjectRef, vm: &VirtualMachine) -> PyResult<()> {
let fd = Fildes::try_from_object(vm, fd).map(Into::into)?;
let seq = size.try_sequence(vm)?;
if seq.length(vm)? != 2 {
return Err(vm.new_type_error("tcsetwinsize: size must be a 2 element sequence"));
}
let row = seq.get_item(0, vm)?;
let col = seq.get_item(1, vm)?;

let row: u16 = row.try_index(vm)?.try_to_primitive(vm)?;
let col: u16 = col.try_index(vm)?.try_to_primitive(vm)?;

host_termios::tcsetwinsize(fd, row, col).map_err(|e| termios_error(e, vm))?;
Ok(())
}

fn termios_error(err: std::io::Error, vm: &VirtualMachine) -> PyBaseExceptionRef {
vm.new_os_subtype_error(
error_type(vm),
Expand Down
Loading