Skip to content

Fix building against new libc#8343

Merged
youknowone merged 1 commit into
RustPython:mainfrom
joshuamegnauth54:fix-nix-ci
Jul 22, 2026
Merged

Fix building against new libc#8343
youknowone merged 1 commit into
RustPython:mainfrom
joshuamegnauth54:fix-nix-ci

Conversation

@joshuamegnauth54

@joshuamegnauth54 joshuamegnauth54 commented Jul 21, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

The Ubuntu build is failing in CI due to a libc change. Check my previous PR to see the build failure.

Summary by CodeRabbit

  • Bug Fixes
    • Improved compatibility when configuring POSIX process-spawn attributes on supported systems.
    • Ensures the correct session-related behavior is applied during new process creation.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: a26998bd-e991-4517-a9de-a2058f85630a

📥 Commits

Reviewing files that changed from the base of the PR and between 443c5f2 and 275bfbf.

📒 Files selected for processing (1)
  • crates/host_env/src/posix.rs
📝 Walkthrough

Walkthrough

Updates POSIX_SPAWN_SETSID conversion in POSIX spawn attribute construction by applying .into() before PosixSpawnFlags::from_bits_retain.

Changes

POSIX spawn flags

Layer / File(s) Summary
Spawn attribute flag conversion
crates/host_env/src/posix.rs		 Converts libc::POSIX_SPAWN_SETSID before passing it to PosixSpawnFlags::from_bits_retain.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: youknowone

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: fixing builds against a newer libc version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@joshuamegnauth54 joshuamegnauth54 mentioned this pull request Jul 21, 2026
Open
2 tasks
ShaharNaveh
ShaharNaveh approved these changes Jul 21, 2026
View reviewed changes

@ShaharNaveh ShaharNaveh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone
youknowone merged commit ea79826 into RustPython:main Jul 22, 2026
26 checks passed
@joshuamegnauth54
joshuamegnauth54 deleted the fix-nix-ci branch July 22, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaharNaveh ShaharNaveh ShaharNaveh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshuamegnauth54 @ShaharNaveh @youknowone