Remove obsolete _symtable APIs#8309
Merged
youknowone merged 1 commit intoJul 18, 2026
Merged
Conversation
stdlib/_symtable.rs previously provided the public Symbol API. When 7f1fc36 imported Lib/symtable.py, responsibility for the public Symbol implementation moved to Python, but the native implementation remained. Remove it along with the unused identifiers getter. Assisted-by: Codex:gpt-5.6-sol
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe symtable module removes the ChangesSymtable API reduction
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_symtable.Symbolimplementation.identifiersgetter from symbol table entries._symtablelimited to the low-level interface consumed byLib/symtable.py.RustPython originally implemented the public
symtableAPI in Rust. After #6048 added CPython'sLib/symtable.py, the publicSymbolimplementation moved to Python and the nativePySymbolbecame unreachable.CPython similarly implements the public
symtable.Symbolclass inLib/symtable.py, rather than exposing it from_symtable.Testing
cargo run --release -- -m test test_symtablecargo test -p rustpython-vmprek run --all-filesAI assistance
Codex (GPT‑5.6 Sol) was used to investigate and implement this change.
I reviewed and validated all AI-assisted work.
Summary by CodeRabbit
Symbolclass from the symbol table API.identifiersaccessor from symbol table entries.symbolsmapping.