-
Notifications
You must be signed in to change notification settings - Fork 1.5k
_queue: check for pending signals during blocking get()
#8252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sigmaith
wants to merge
2
commits into
RustPython:main
Choose a base branch
from
sigmaith:fix/queue-blocking-signals
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+97
−21
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| """A blocking queue.SimpleQueue.get() must stay responsive to signals. | ||
|
|
||
| SimpleQueue.get() waits on a Condvar. A single uninterrupted wait blocks | ||
| Python-level signal handlers (including the default KeyboardInterrupt) until | ||
| the wait itself returns, since signals are only delivered at bytecode | ||
| safepoints. A regression shows up as the handler firing only once get() | ||
| unblocks, instead of promptly when the signal actually arrives. | ||
| """ | ||
|
|
||
| import queue | ||
| import signal | ||
| import sys | ||
| import threading | ||
| import time | ||
|
|
||
| if sys.platform.startswith("win"): | ||
| print("skipped (no SIGALRM)") | ||
| raise SystemExit(0) | ||
|
|
||
| q = queue.SimpleQueue() | ||
| start = time.time() | ||
| handled_at = [] | ||
|
|
||
|
|
||
| def handler(signum, frame): | ||
| handled_at.append(time.time() - start) | ||
|
|
||
|
|
||
| signal.signal(signal.SIGALRM, handler) | ||
| signal.setitimer(signal.ITIMER_REAL, 0.3) | ||
|
|
||
|
|
||
| def unblock_later(): | ||
| time.sleep(1.5) | ||
| q.put("unblock") | ||
|
|
||
|
|
||
| threading.Thread(target=unblock_later, daemon=True).start() | ||
|
|
||
| item = q.get() # blocks until unblock_later() wakes us up | ||
| elapsed = time.time() - start | ||
|
|
||
| assert item == "unblock", item | ||
| assert handled_at, "signal handler never ran" | ||
| # The handler should fire around t=0.3s, when the timer was started, not t=1.5s | ||
| # (when get() finally unblocked). | ||
| assert handled_at[0] < elapsed - 0.5, ( | ||
| f"signal handled at {handled_at[0]:.2f}s but get() only returned at " | ||
| f"{elapsed:.2f}s -- signal was not processed while blocked" | ||
| ) | ||
|
|
||
| print("ok") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this line has CPython reference?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No CPython citation for 50ms, It was empirical choice.
CPython doesn't chunk either; it makes one
sem_timedwaitcall and relies onEINTR.parking_lot'scondvardoesn't expose signal interruptions to us the way CPython does, So I think polling is the workaround. Comment updated to reflect this.